Missing service informer - #338
Merged
openshift-merge-robot merged 3 commits intoNov 5, 2019
Merged
Conversation
openshift-ci-robot
added
the
size/M
This was referenced Nov 5, 2019
| kubeClient.CoreV1(), | ||
| kubeInformersNamespaced.Core().V1().Services(), | ||
| // clients | ||
| operatorConfigClient.OperatorV1().Consoles(), // operator config so we can update status |
Contributor
There was a problem hiding this comment.
Nice, mind pairing them up?
OperatorClient
OperatorInformer
ServiceClient
ServiceInformer
Contributor
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: benjaminapetersen, jhadvig The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The issue of the failing Unmanaged e2e tests was that the new ServiceController haven't picked up changes in the consoleoperator config, eg: change from
UnmanagedtoManagedstate.Due to this the
consoleservice has not been recreated and the console pods could not start since cause of that theconsole-serving-certsecret was missing.Also adding the
StandardSetupcall from #329, which this PR shoud replace.Also removing the skipping of the failing tests, which should replace #336 since there is no point to have two PR for that.
/assign @benjaminapetersen