Skip to content

Unify testing resources in e2e tests - #340

Merged
openshift-merge-robot merged 1 commit into
openshift:masterfrom
jhadvig:e2e-unify
Nov 7, 2019
Merged

Unify testing resources in e2e tests#340
openshift-merge-robot merged 1 commit into
openshift:masterfrom
jhadvig:e2e-unify

Conversation

@jhadvig

@jhadvig jhadvig commented Nov 5, 2019

Copy link
Copy Markdown
Member

We haven't been consistent with the resources that we are GETting and DELETEing

/assign @benjaminapetersen

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 5, 2019
@benjaminapetersen

benjaminapetersen commented Nov 5, 2019

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 5, 2019
@jhadvig

jhadvig commented Nov 5, 2019

Copy link
Copy Markdown
Member Author

/retest

@jhadvig

jhadvig commented Nov 6, 2019

Copy link
Copy Markdown
Member Author

/retest

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Nov 6, 2019
@jhadvig

jhadvig commented Nov 6, 2019

Copy link
Copy Markdown
Member Author

@benjaminapetersen had to update the PR. Forgot that we dont test availability of the console-public CM in the openshift-config-managed NS, in the TestRemoved and TestUnamanagedsince we are only syncing the CM's data.
Will probably create a separate TC for each managemenet state of the operator, but now this should reflect the current state of the e2e tests.
PTAL

@jhadvig

jhadvig commented Nov 6, 2019

Copy link
Copy Markdown
Member Author

/retest

1 similar comment
@jhadvig

jhadvig commented Nov 6, 2019

Copy link
Copy Markdown
Member Author

/retest

@benjaminapetersen

benjaminapetersen commented Nov 7, 2019

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 7, 2019
@openshift-ci-robot

openshift-ci-robot commented Nov 7, 2019

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: benjaminapetersen, jhadvig

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jhadvig

jhadvig commented Nov 7, 2019

Copy link
Copy Markdown
Member Author

/retest

@openshift-merge-robot
openshift-merge-robot merged commit 0208d19 into openshift:master Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@spadgett spadgett Awaiting requested review from spadgett
1 more reviewer
@benjaminapetersen benjaminapetersen benjaminapetersen approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@benjaminapetersen benjaminapetersen

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jhadvig @benjaminapetersen @openshift-ci-robot @openshift-merge-robot