Dockerfile changes for OpenShift by spadgett · Pull Request #125 · openshift/console

spadgett · 2018-06-12T19:23:52Z

Use openshift/origin-base as the base image
Add image labels and user

/cc @adammhaile @jwforres

spadgett · 2018-06-12T19:24:56Z

jenkins push

coreos-ui · 2018-06-12T19:43:42Z

The PR image has been pushed to Quay with tag pr_125_build_369

spadgett · 2018-06-12T19:57:32Z

jenkins push

benjaminapetersen · 2018-06-12T20:01:56Z

Interesting, is our own base image a new thing?

It's used by a few other components and OpenShift CI for builds.

Note... we don't actually ever build with this image as a base. It will be replaced with openshift3/ose-base in our process.
If you need this to also build in origin, then what you have is definitely the way to go. However, I am concerned about the golang-1.9 tag. That's not something I'm familiar with. We build openshift3/ose-base during the OCP build so that version will be what this image is built with.

This is a multistage build. The first image is only used for building the Go binary.

https://docs.docker.com/develop/develop-images/multistage-build/

We have FROM openshift/origin-base later. Does the tooling support that?

It doesn't yet, but this will be a guinea pig for that capability in OSBS.

coreos-ui · 2018-06-12T20:17:27Z

The PR image has been pushed to Quay with tag pr_125_build_371

spadgett · 2018-06-13T02:16:28Z

/hold

stevekuznetsov · 2018-06-13T20:50:33Z

/test backend

spadgett · 2018-06-18T18:17:19Z

@stevekuznetsov This now adds a Dockerfile.ci, but I'm not sure it should be needed looking at

https://github.com/openshift/release/blob/master/ci-operator/config/openshift/console/master.json

ci/prow/* jobs are failing, though.

stevekuznetsov · 2018-06-18T23:22:52Z

ci/prow/ jobs should be fixed by openshift/ci-operator#25

* Use openshift/origin-base as the base image * Add image labels and user

spadgett · 2018-06-19T13:17:05Z

OK, I've updated this PR just to switch the base image and add labels and user.

spadgett · 2018-06-19T13:17:29Z

jenkins push

coreos-ui · 2018-06-19T13:33:40Z

The PR image has been pushed to Quay with tag pr_125_build_385

spadgett · 2018-06-19T13:41:53Z

I updated the CI cluster with an image built from this Dockerfile.

@jwforres PTAL

stevekuznetsov · 2018-06-19T18:08:57Z

/test all

openshift-ci-robot · 2018-06-19T18:18:01Z

@spadgett: The following tests failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
ci/prow/crud	`5b687af`	link	`/test crud`
ci/prow/alm	`5b687af`	link	`/test alm`
ci/prow/performance	`5b687af`	link	`/test performance`

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

jwforres · 2018-06-19T18:24:16Z

LGTM for first pass to switch base image

spadgett · 2018-06-19T18:36:09Z

I'll work on any changes needed for OSBS in a follow on.

* add AddLabel option component * fix import and props type variable name * add props to pass back the value to component and use name-value-editor component * move component to shared component folder

…ice-dashboard Add object-service-dashboard test

openshift-ci-robot requested a review from adammhaile June 12, 2018 19:23

openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 12, 2018

openshift-ci-robot requested a review from jwforres June 12, 2018 19:23

openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 12, 2018

spadgett force-pushed the multi-stage-dockerfile branch from 771b48b to 299cd61 Compare June 12, 2018 19:57

benjaminapetersen reviewed Jun 12, 2018

View reviewed changes

spadgett changed the title ~~[WIP] Dockerfile changes for OpenShift~~ Dockerfile changes for OpenShift Jun 12, 2018

openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 12, 2018

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 13, 2018

spadgett force-pushed the multi-stage-dockerfile branch 3 times, most recently from b360baa to c0cd76a Compare June 18, 2018 17:59

openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 18, 2018

spadgett force-pushed the multi-stage-dockerfile branch from c0cd76a to f7a4ac4 Compare June 18, 2018 18:15

spadgett force-pushed the multi-stage-dockerfile branch from f7a4ac4 to 6968a70 Compare June 19, 2018 13:15

openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 19, 2018

Dockerfile changes for OpenShift

5b687af

* Use openshift/origin-base as the base image * Add image labels and user

spadgett force-pushed the multi-stage-dockerfile branch from 6968a70 to 5b687af Compare June 19, 2018 13:16

jwforres approved these changes Jun 19, 2018

View reviewed changes

spadgett merged commit 782ef2d into openshift:master Jun 19, 2018

spadgett deleted the multi-stage-dockerfile branch June 19, 2018 18:37

spadgett mentioned this pull request Jun 19, 2018

[DO NOT MERGE] Use openshift/origin-base image #110

Closed

TimothyAsirJeyasing pushed a commit to TimothyAsirJeyasing/console that referenced this pull request Aug 3, 2022

Merge pull request openshift#125 from TimothyAsirJeyasing/object-serv…

b6f9640

…ice-dashboard Add object-service-dashboard test

coderabbitai Bot mentioned this pull request Aug 8, 2026

Update dependency @playwright/test to v1.62.0 openshift/lightspeed-agentic-console#198

Open

1 task

Uh oh!

Conversation

spadgett commented Jun 12, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

spadgett commented Jun 12, 2018

Uh oh!

coreos-ui commented Jun 12, 2018

Uh oh!

spadgett commented Jun 12, 2018

Uh oh!

benjaminapetersen Jun 12, 2018

Choose a reason for hiding this comment

Uh oh!

spadgett Jun 12, 2018

Choose a reason for hiding this comment

Uh oh!

adammhaile Jun 13, 2018

Choose a reason for hiding this comment

Uh oh!

spadgett Jun 13, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sosiouxme Jun 14, 2018

Choose a reason for hiding this comment

Uh oh!

coreos-ui commented Jun 12, 2018

Uh oh!

spadgett commented Jun 13, 2018

Uh oh!

stevekuznetsov commented Jun 13, 2018

Uh oh!

spadgett commented Jun 18, 2018

Uh oh!

stevekuznetsov commented Jun 18, 2018

Uh oh!

spadgett commented Jun 19, 2018

Uh oh!

spadgett commented Jun 19, 2018

Uh oh!

coreos-ui commented Jun 19, 2018

Uh oh!

spadgett commented Jun 19, 2018

Uh oh!

stevekuznetsov commented Jun 19, 2018

Uh oh!

openshift-ci-robot commented Jun 19, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jwforres commented Jun 19, 2018

Uh oh!

spadgett commented Jun 19, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

spadgett commented Jun 12, 2018 •

edited

Loading

spadgett Jun 13, 2018 •

edited

Loading

openshift-ci-robot commented Jun 19, 2018 •

edited

Loading