[release-4.22] OCPBUGS-85196: Remove @console imports from SDK dist#16407
Conversation
Define and export UserKind in extensions/console-types, remove the duplicate definition from public k8s types, and update affected files to import UserKind/UserInfo from the extensions path. Replace PaneBody with PatternFly PageSection in ListPageBody. Change k8s resource fetch import to use consoleFetchJSON (aliased as coFetchJSON) from lib-core. Add a test (sdk-dist-imports.spec.ts) that scans the SDK dist output to ensure no ES import/export statements reference monorepo packages, preventing accidental bundling of internal module specifiers.
openshift-ci
Bot
added
component/core
|
@openshift-cherrypick-robot: Jira Issue OCPBUGS-85043 has been cloned as Jira Issue OCPBUGS-85196. Will retitle bug to link to clone. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
Bot
changed the title
@console imports from SDK dist@console imports from SDK dist
openshift-ci-robot
added
jira/valid-reference
|
@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-85196, which is valid. The bug has been moved to the POST state. 7 validation(s) were run on this bug
The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
logonoff
left a comment
logonoff
left a comment
There was a problem hiding this comment.
/label backport-risk-assessed
/lgtm
openshift-ci
Bot
added
the
backport-risk-assessed
|
/verified by @logonoff |
|
/label plugin-api-approved |
openshift-ci
Bot
added
the
approved
openshift-ci-robot
added
the
verified
|
@logonoff: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
Bot
added
the
plugin-api-approved
Move consoleFetch, consoleFetchJSON, and consoleFetchText from core-api.ts into a new console-fetch.ts module. This breaks the circular dependency (k8s-resource → lib-core → core-api → utils/k8s → k8s-resource) by allowing k8s-resource.ts to import consoleFetchJSON from console-fetch.ts, which has no back-edge into the k8s utils. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
rhamilto
force-pushed
the
cherry-pick-16399-to-release-4.22
branch
from
9a5fb5a to
15c42f7
Compare
openshift-ci-robot
removed
the
verified
|
built monitoring plugin locally and observed no buildtime issues /lgtm |
openshift-ci-robot
added
the
verified
|
@logonoff: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: logonoff, openshift-cherrypick-robot The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@openshift-cherrypick-robot: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
openshift-merge-bot
Bot
merged commit 21c095c
into
openshift:release-4.22
|
@openshift-cherrypick-robot: Jira Issue Verification Checks: Jira Issue OCPBUGS-85196 Jira Issue OCPBUGS-85196 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
7 participants
This is an automated cherry-pick of #16399
/assign logonoff