OCPBUGS-82506, OCPBUGS-82507: Re-enable OLM Cypress tests disabled for createRoot

[TheRealJon]

Summary

Re-enable operator-hub.cy.ts and operator-install-global.cy.ts e2e tests that were disabled during the React 18 createRoot migration (CONSOLE-4512).

Changes

OCPBUGS-82506: operator-hub.cy.ts

• Root cause: React 18 concurrent rendering batches catalog tile updates asynchronously via startTransition (CatalogView.tsx:132). Test asserted tile content changed immediately after filter click without waiting for async re-render.
• Fix: Changed filter assertion at lines 42-51 from immediate invoke('text').should() to retry-based .should() callback that re-executes text extraction on each retry attempt. Properly handles async tile re-rendering under concurrent mode.

OCPBUGS-82507: operator-install-global.cy.ts

• Root cause: Install mode radio buttons mount after async data loads via useK8sWatchResource hooks in operator-hub-subscribe.tsx. Concurrent rendering batches these async operations, causing 30s timeout to be insufficient.
• Fix: Increased install mode radio timeout from 30s to 60s in operator.view.ts (lines 48, 63) to handle deferred rendering timing.

Test Plan

• operator-hub.cy.ts passes in CI under createRoot
• operator-install-global.cy.ts passes in CI under createRoot
• No regressions in other OLM Cypress tests

Related

• Blocks: CONSOLE-5237 (Migrate OLM integration-tests to Playwright)
• Related: CONSOLE-4512 (Update to React 18 - Phase 2)

🤖 Generated with Claude Code

Summary by CodeRabbit

• Tests
  • Improved test reliability for operator installation and catalog filtering scenarios with enhanced timeout handling.
  • Re-enabled integration test coverage for global operator installation workflow.

[openshift-ci-robot]

@TheRealJon: This pull request references Jira Issue OCPBUGS-82506, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (5.0.0) matches configured target version for branch (5.0.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

This pull request references Jira Issue OCPBUGS-82507, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (5.0.0) matches configured target version for branch (5.0.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Summary

Re-enable operator-hub.cy.ts and operator-install-global.cy.ts e2e tests that were disabled during the React 18 createRoot migration (CONSOLE-4512).

Changes

OCPBUGS-82506: operator-hub.cy.ts

• Root cause: React 18 concurrent rendering batches catalog tile updates asynchronously via startTransition (CatalogView.tsx:132). Test asserted tile content changed immediately after filter click without waiting for async re-render.
• Fix: Changed filter assertion at lines 42-51 from immediate invoke('text').should() to retry-based .should() callback that re-executes text extraction on each retry attempt. Properly handles async tile re-rendering under concurrent mode.

OCPBUGS-82507: operator-install-global.cy.ts

• Root cause: Install mode radio buttons mount after async data loads via useK8sWatchResource hooks in operator-hub-subscribe.tsx. Concurrent rendering batches these async operations, causing 30s timeout to be insufficient.
• Fix: Increased install mode radio timeout from 30s to 60s in operator.view.ts (lines 48, 63) to handle deferred rendering timing.

Test Plan

• operator-hub.cy.ts passes in CI under createRoot
• operator-install-global.cy.ts passes in CI under createRoot
• No regressions in other OLM Cypress tests

Related

• Blocks: CONSOLE-5237 (Migrate OLM integration-tests to Playwright)
• Related: CONSOLE-4512 (Update to React 18 - Phase 2)

🤖 Generated with Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@TheRealJon: This pull request references Jira Issue OCPBUGS-82506, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (5.0.0) matches configured target version for branch (5.0.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

This pull request references Jira Issue OCPBUGS-82507, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (5.0.0) matches configured target version for branch (5.0.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Details

In response to this:

Summary

Re-enable operator-hub.cy.ts and operator-install-global.cy.ts e2e tests that were disabled during the React 18 createRoot migration (CONSOLE-4512).

Changes

OCPBUGS-82506: operator-hub.cy.ts

• Root cause: React 18 concurrent rendering batches catalog tile updates asynchronously via startTransition (CatalogView.tsx:132). Test asserted tile content changed immediately after filter click without waiting for async re-render.
• Fix: Changed filter assertion at lines 42-51 from immediate invoke('text').should() to retry-based .should() callback that re-executes text extraction on each retry attempt. Properly handles async tile re-rendering under concurrent mode.

OCPBUGS-82507: operator-install-global.cy.ts

• Root cause: Install mode radio buttons mount after async data loads via useK8sWatchResource hooks in operator-hub-subscribe.tsx. Concurrent rendering batches these async operations, causing 30s timeout to be insufficient.
• Fix: Increased install mode radio timeout from 30s to 60s in operator.view.ts (lines 48, 63) to handle deferred rendering timing.

Test Plan

• operator-hub.cy.ts passes in CI under createRoot
• operator-install-global.cy.ts passes in CI under createRoot
• No regressions in other OLM Cypress tests

Related

• Blocks: CONSOLE-5237 (Migrate OLM integration-tests to Playwright)
• Related: CONSOLE-4512 (Update to React 18 - Phase 2)

🤖 Generated with Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: dbe5bc48-51a7-4409-9b05-8e963bde0602

📥 Commits

Reviewing files that changed from the base of the PR and between 07a33c7 and 0ac99f0.

📒 Files selected for processing (3)

• frontend/packages/operator-lifecycle-manager/integration-tests/tests/operator-hub.cy.ts
• frontend/packages/operator-lifecycle-manager/integration-tests/tests/operator-install-global.cy.ts
• frontend/packages/operator-lifecycle-manager/integration-tests/views/operator.view.ts

---

Walkthrough

Integration tests for Operator Lifecycle Manager are updated to tolerate React 18 concurrent rendering behavior. Cypress timeouts for namespace radio selectors are increased, the operator hub filter test assertion is retrofitted to wait for async DOM updates, and two previously disabled test suites are re-enabled.

Changes

React 18 Concurrent Rendering Test Compatibility

Layer / File(s)	Summary
Operator view namespace selector timeouts frontend/packages/operator-lifecycle-manager/integration-tests/views/operator.view.ts	Cypress timeouts for "A specific namespace on the cluster" and "All namespaces on the cluster" radio selectors increased from 30s to 60s with comments noting React 18 deferred mounting behavior after async data loads.
Operator Hub catalog filter assertion frontend/packages/operator-lifecycle-manager/integration-tests/tests/operator-hub.cy.ts	"Interacting with Operators" test suite enabled; tile title assertion logic replaced with .should() callback that retries until the title differs from the pre-filter Community value, accommodating React 18 batched async re-renders.
Global operator install test re-enable frontend/packages/operator-lifecycle-manager/integration-tests/tests/operator-install-global.cy.ts	Test suite wrapper changed from disabled xdescribe to active describe, re-enabling the globally-installed Data Grid operator integration test with existing setup, teardown, and operand lifecycle steps.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

• openshift/console#16517: Adjusts the same operator.view.ts namespace radio selectors to handle React 18 concurrent rendering and re-enables related Data Grid e2e test suites.

Suggested labels

approved, lgtm, component/olm, kind/cypress, jira/valid-bug, jira/valid-reference, verified

Suggested reviewers

• fsgreco
• jhadvig
• logonoff

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and specifically references the two Jira bugs being fixed (OCPBUGS-82506 and OCPBUGS-82507) and describes the main objective: re-enabling OLM Cypress tests disabled for createRoot.
Description check	✅ Passed	The description includes analysis/root cause for both bugs, detailed solution descriptions with code references, test plan checkboxes, and related Jira links, addressing all required sections from the template.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The custom check is for Ginkgo test names (Go backend tests), but this PR only modifies Cypress tests (TypeScript frontend). The check is not applicable to this PR.
Test Structure And Quality	✅ Passed	Custom check for Ginkgo test code is not applicable to this PR. The modified files are Cypress (.cy.ts) integration tests, not Ginkgo tests. Different test frameworks with different quality criteria.
Microshift Test Compatibility	✅ Passed	The custom check is for Ginkgo e2e tests, but this PR contains only Cypress frontend integration tests (.cy.ts files). The check is not applicable to Cypress tests.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	This PR only modifies Cypress integration tests (.cy.ts files), not Ginkgo e2e tests. The custom check for SNO compatibility applies only to Ginkgo tests, not Cypress UI tests.
Topology-Aware Scheduling Compatibility	✅ Passed	Changes only modify Cypress integration test files in integration-tests/. No deployment manifests, operator code, or controllers with scheduling constraints are altered.
Ote Binary Stdout Contract	✅ Passed	PR modifies only frontend TypeScript/Cypress test files; OTE Binary Stdout Contract applies only to Go backend binaries with Ginkgo/klog, which are not modified here.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	This PR modifies Cypress frontend e2e tests (TypeScript), not Ginkgo e2e tests (Go). The custom check is designed for Ginkgo tests only, making it not applicable to this PR.
No-Weak-Crypto	✅ Passed	No weak cryptography patterns found. All changes are test infrastructure improvements for React 18 compatibility with no crypto operations.
Container-Privileges	✅ Passed	PR contains only TypeScript Cypress test files with no Kubernetes manifests or container configurations; the container-privileges check is not applicable.
No-Sensitive-Data-In-Logs	✅ Passed	PR contains no logging of sensitive data. All cy.log statements log only test instructions, operator/namespace names, and UI text content—no passwords, tokens, API keys, PII, or credentials.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[TheRealJon]

/verified by CI

[openshift-ci-robot]

@TheRealJon: This PR has been marked as verified by CI.

Details

In response to this:

/verified by CI

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[TheRealJon]

/retest

Seems to be an unrelated flake

[rhamilto]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhamilto, TheRealJon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• frontend/OWNERS [TheRealJon,rhamilto]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-merge-bot]

/retest-required

Remaining retests: 0 against base HEAD 76aa7c8 and 2 for PR HEAD 0ac99f0 in total

[openshift-ci]

@TheRealJon: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-ci-robot]

@TheRealJon: Jira Issue Verification Checks: Jira Issue OCPBUGS-82506
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-82506 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Jira Issue Verification Checks: Jira Issue OCPBUGS-82507
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-82507 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

Summary

Re-enable operator-hub.cy.ts and operator-install-global.cy.ts e2e tests that were disabled during the React 18 createRoot migration (CONSOLE-4512).

Changes

OCPBUGS-82506: operator-hub.cy.ts

• Root cause: React 18 concurrent rendering batches catalog tile updates asynchronously via startTransition (CatalogView.tsx:132). Test asserted tile content changed immediately after filter click without waiting for async re-render.
• Fix: Changed filter assertion at lines 42-51 from immediate invoke('text').should() to retry-based .should() callback that re-executes text extraction on each retry attempt. Properly handles async tile re-rendering under concurrent mode.

OCPBUGS-82507: operator-install-global.cy.ts

• Root cause: Install mode radio buttons mount after async data loads via useK8sWatchResource hooks in operator-hub-subscribe.tsx. Concurrent rendering batches these async operations, causing 30s timeout to be insufficient.
• Fix: Increased install mode radio timeout from 30s to 60s in operator.view.ts (lines 48, 63) to handle deferred rendering timing.

Test Plan

• operator-hub.cy.ts passes in CI under createRoot
• operator-install-global.cy.ts passes in CI under createRoot
• No regressions in other OLM Cypress tests

Related

• Blocks: CONSOLE-5237 (Migrate OLM integration-tests to Playwright)
• Related: CONSOLE-4512 (Update to React 18 - Phase 2)

🤖 Generated with Claude Code

Summary by CodeRabbit

• Tests
• Improved test reliability for operator installation and catalog filtering scenarios with enhanced timeout handling.
• Re-enabled integration test coverage for global operator installation workflow.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.