Skip to content

OCPBUGS-94168: Fix CVE-2026-13149 brace-expansion DoS vulnerability#16812

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
rhamilto:OCPBUGS-94168
Jul 23, 2026
Merged

OCPBUGS-94168: Fix CVE-2026-13149 brace-expansion DoS vulnerability#16812
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
rhamilto:OCPBUGS-94168

Conversation

@rhamilto

@rhamilto rhamilto commented Jul 23, 2026

Copy link
Copy Markdown
Member

Analysis / Root cause:
CVE-2026-13149 — brace-expansion through 5.0.6 is vulnerable to denial of service. The expand() function exhibits exponential-time complexity (O(2^n)) in the number of consecutive non-expanding {} brace groups. A ~90 byte payload can block the calling thread for minutes. The max option does not mitigate this.

The repo carried three vulnerable transitive copies via minimatch: 1.1.12 (via minimatch 3.1.5), 2.1.0 (via minimatch 9.0.9), and 5.0.5 (via minimatch 10.2.5).

Jira: https://redhat.atlassian.net/browse/OCPBUGS-94168

Solution description:
Add per-descriptor yarn resolutions to bump each brace-expansion major line to its patched release:

  • brace-expansion@npm:^1.1.71.1.16 (for minimatch 3.x)
  • brace-expansion@npm:^2.0.22.1.2 (for minimatch 9.x)
  • brace-expansion@npm:^5.0.55.0.7 (for minimatch 10.x)

Each resolution targets a specific descriptor to preserve API compatibility within its major line. A blanket >=1.1.16 resolution was attempted first but broke minimatch 3.x because brace-expansion 5.x has an incompatible API (expand is not a function).

Screenshots / screen recording:
N/A — dependency-only change with no UI impact.

Test setup:
N/A

Test cases:

  • yarn build completes successfully with the updated dependencies.
  • yarn lint passes (verifies eslint-plugin-import's no-extraneous-dependencies rule works with the updated brace-expansion, which was the failure mode of the first attempt).

Browser conformance:

  • Chrome
  • Firefox
  • Safari (or Epiphany on Linux)

N/A — no runtime behavior change.

Additional info:

  • CVSS 5.3 (Medium) — CWE-400, CWE-407
  • Fixed versions: 1.1.16, 2.1.2, 5.0.7

Reviewers and assignees:

Summary by CodeRabbit

  • Chores
    • Updated package resolution settings to ensure compatible versions of required components are used, including keeping protobufjs pinned and adding brace-expansion overrides for more targeted version control.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Jul 23, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@rhamilto: This pull request references Jira Issue OCPBUGS-94168, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (5.0.0) matches configured target version for branch (5.0.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Analysis / Root cause:
CVE-2026-13149 — brace-expansion through 5.0.6 is vulnerable to denial of service. The expand() function exhibits exponential-time complexity (O(2^n)) in the number of consecutive non-expanding {} brace groups. A ~90 byte payload can block the calling thread for minutes. The max option does not mitigate this.

The repo carried three vulnerable transitive copies via minimatch: 1.1.12 (via minimatch 3.1.5), 2.1.0 (via minimatch 9.0.9), and 5.0.5 (via minimatch 10.2.5).

Jira: https://redhat.atlassian.net/browse/OCPBUGS-94168

Solution description:
Add a yarn resolution "brace-expansion": ">=1.1.16" to force all transitive copies to resolve to the fixed 5.0.7 release.

Screenshots / screen recording:
N/A — dependency-only change with no UI impact.

Test setup:
N/A

Test cases:

  • yarn build completes successfully with the updated dependency.

Browser conformance:

  • Chrome
  • Firefox
  • Safari (or Epiphany on Linux)

N/A — no runtime behavior change.

Additional info:

  • CVSS 5.3 (Medium) — CWE-400, CWE-407
  • Fixed versions: 1.1.16, 2.1.2, 5.0.7

Reviewers and assignees:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai

coderabbitai Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Walkthrough

The Yarn resolutions block adds overrides for brace-expansion versions 1.1.16, 2.1.2, and 5.0.7 while retaining the protobufjs pin at 7.5.8.

Changes

Dependency resolution

Layer / File(s) Summary
Yarn resolution overrides
frontend/package.json
Adds brace-expansion overrides for three semver ranges and preserves the protobufjs resolution at 7.5.8.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: therealjon, fsgreco, logonoff

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR only changes frontend/package.json and yarn.lock; no test files or Ginkgo titles were added or modified.
Test Structure And Quality ✅ Passed PR only changes frontend/package.json and yarn.lock for dependency resolutions; no Ginkgo test code changed, so the test-structure check is not applicable.
Microshift Test Compatibility ✅ Passed Only frontend/package.json and yarn.lock changed; no new Ginkgo e2e tests or test files were added.
Single Node Openshift (Sno) Test Compatibility ✅ Passed Only package.json and yarn.lock changed; no Ginkgo/e2e tests were added or modified, so SNO compatibility is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed PR only updates frontend dependency resolutions and the lockfile; no deployment manifests, operators, or controllers were modified, so topology-aware scheduling doesn't apply.
Ote Binary Stdout Contract ✅ Passed PR only changes frontend/package.json and frontend/yarn.lock for brace-expansion resolutions; no process-level stdout-writing code was added.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed Only frontend dependency resolution and yarn.lock changed; no new Ginkgo e2e tests or network assumptions were added.
No-Weak-Crypto ✅ Passed The patch only updates brace-expansion/yarn resolutions; no MD5/SHA1/DES/RC4/3DES/Blowfish/ECB, custom crypto, or secret comparisons were added.
Container-Privileges ✅ Passed PR only updates frontend/package.json resolutions and yarn.lock; no container/K8s manifests or privilege-related fields are touched.
No-Sensitive-Data-In-Logs ✅ Passed Only dependency-resolution changes in package.json/yarn.lock; no logging code or sensitive-data literals were added.
Title check ✅ Passed The title clearly states the Jira bug and the brace-expansion CVE fix, matching the main change.
Description check ✅ Passed All required template sections are present with substantive content, including root cause, solution, tests, and browser conformance.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@rhamilto: This pull request references Jira Issue OCPBUGS-94168, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (5.0.0) matches configured target version for branch (5.0.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
Details

In response to this:

Analysis / Root cause:
CVE-2026-13149 — brace-expansion through 5.0.6 is vulnerable to denial of service. The expand() function exhibits exponential-time complexity (O(2^n)) in the number of consecutive non-expanding {} brace groups. A ~90 byte payload can block the calling thread for minutes. The max option does not mitigate this.

The repo carried three vulnerable transitive copies via minimatch: 1.1.12 (via minimatch 3.1.5), 2.1.0 (via minimatch 9.0.9), and 5.0.5 (via minimatch 10.2.5).

Jira: https://redhat.atlassian.net/browse/OCPBUGS-94168

Solution description:
Add a yarn resolution "brace-expansion": ">=1.1.16" to force all transitive copies to resolve to the fixed 5.0.7 release.

Screenshots / screen recording:
N/A — dependency-only change with no UI impact.

Test setup:
N/A

Test cases:

  • yarn build completes successfully with the updated dependency.

Browser conformance:

  • Chrome
  • Firefox
  • Safari (or Epiphany on Linux)

N/A — no runtime behavior change.

Additional info:

  • CVSS 5.3 (Medium) — CWE-400, CWE-407
  • Fixed versions: 1.1.16, 2.1.2, 5.0.7

Reviewers and assignees:

Summary by CodeRabbit

  • Chores
  • Updated package resolution settings to ensure compatible versions of required components are used.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
openshift-ci Bot requested review from TheRealJon and fsgreco July 23, 2026 16:44
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 23, 2026
Add per-descriptor yarn resolutions to bump each brace-expansion major
line to its patched release (1.1.16, 2.1.2, 5.0.7), preserving API
compatibility with minimatch 3.x, 9.x, and 10.x respectively.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@rhamilto: This pull request references Jira Issue OCPBUGS-94168. The bug has been updated to no longer refer to the pull request using the external bug tracker.

Details

In response to this:

Analysis / Root cause:
CVE-2026-13149 — brace-expansion through 5.0.6 is vulnerable to denial of service. The expand() function exhibits exponential-time complexity (O(2^n)) in the number of consecutive non-expanding {} brace groups. A ~90 byte payload can block the calling thread for minutes. The max option does not mitigate this.

The repo carried three vulnerable transitive copies via minimatch: 1.1.12 (via minimatch 3.1.5), 2.1.0 (via minimatch 9.0.9), and 5.0.5 (via minimatch 10.2.5).

Jira: https://redhat.atlassian.net/browse/OCPBUGS-94168

Solution description:
Add per-descriptor yarn resolutions to bump each brace-expansion major line to its patched release:

  • brace-expansion@npm:^1.1.71.1.16 (for minimatch 3.x)
  • brace-expansion@npm:^2.0.22.1.2 (for minimatch 9.x)
  • brace-expansion@npm:^5.0.55.0.7 (for minimatch 10.x)

Each resolution targets a specific descriptor to preserve API compatibility within its major line. A blanket >=1.1.16 resolution was attempted first but broke minimatch 3.x because brace-expansion 5.x has an incompatible API (expand is not a function).

Screenshots / screen recording:
N/A — dependency-only change with no UI impact.

Test setup:
N/A

Test cases:

  • yarn build completes successfully with the updated dependencies.
  • yarn lint passes (verifies eslint-plugin-import's no-extraneous-dependencies rule works with the updated brace-expansion, which was the failure mode of the first attempt).

Browser conformance:

  • Chrome
  • Firefox
  • Safari (or Epiphany on Linux)

N/A — no runtime behavior change.

Additional info:

  • CVSS 5.3 (Medium) — CWE-400, CWE-407
  • Fixed versions: 1.1.16, 2.1.2, 5.0.7

Reviewers and assignees:

Summary by CodeRabbit

  • Chores
  • Updated package resolution settings to ensure compatible versions of required components are used, including keeping protobufjs pinned and adding brace-expansion overrides for more targeted version control.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@rhamilto rhamilto reopened this Jul 23, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@rhamilto: This pull request references Jira Issue OCPBUGS-94168, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (5.0.0) matches configured target version for branch (5.0.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Analysis / Root cause:
CVE-2026-13149 — brace-expansion through 5.0.6 is vulnerable to denial of service. The expand() function exhibits exponential-time complexity (O(2^n)) in the number of consecutive non-expanding {} brace groups. A ~90 byte payload can block the calling thread for minutes. The max option does not mitigate this.

The repo carried three vulnerable transitive copies via minimatch: 1.1.12 (via minimatch 3.1.5), 2.1.0 (via minimatch 9.0.9), and 5.0.5 (via minimatch 10.2.5).

Jira: https://redhat.atlassian.net/browse/OCPBUGS-94168

Solution description:
Add per-descriptor yarn resolutions to bump each brace-expansion major line to its patched release:

  • brace-expansion@npm:^1.1.71.1.16 (for minimatch 3.x)
  • brace-expansion@npm:^2.0.22.1.2 (for minimatch 9.x)
  • brace-expansion@npm:^5.0.55.0.7 (for minimatch 10.x)

Each resolution targets a specific descriptor to preserve API compatibility within its major line. A blanket >=1.1.16 resolution was attempted first but broke minimatch 3.x because brace-expansion 5.x has an incompatible API (expand is not a function).

Screenshots / screen recording:
N/A — dependency-only change with no UI impact.

Test setup:
N/A

Test cases:

  • yarn build completes successfully with the updated dependencies.
  • yarn lint passes (verifies eslint-plugin-import's no-extraneous-dependencies rule works with the updated brace-expansion, which was the failure mode of the first attempt).

Browser conformance:

  • Chrome
  • Firefox
  • Safari (or Epiphany on Linux)

N/A — no runtime behavior change.

Additional info:

  • CVSS 5.3 (Medium) — CWE-400, CWE-407
  • Fixed versions: 1.1.16, 2.1.2, 5.0.7

Reviewers and assignees:

Summary by CodeRabbit

  • Chores
  • Updated package resolution settings to ensure compatible versions of required components are used, including keeping protobufjs pinned and adding brace-expansion overrides for more targeted version control.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@rhamilto

Copy link
Copy Markdown
Member Author

/jira refresh

@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@rhamilto: This pull request references Jira Issue OCPBUGS-94168, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (5.0.0) matches configured target version for branch (5.0.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@shahsahil264 shahsahil264 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 23, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-gcp-console
/test e2e-playwright

@openshift-ci

openshift-ci Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhamilto, shahsahil264

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rhamilto

Copy link
Copy Markdown
Member Author

/pipeline required

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-gcp-console
/test e2e-playwright

@rhamilto

Copy link
Copy Markdown
Member Author

/verified by CI

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Jul 23, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@rhamilto: This PR has been marked as verified by CI.

Details

In response to this:

/verified by CI

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-bot
openshift-merge-bot Bot merged commit 4cf941d into openshift:main Jul 23, 2026
10 of 11 checks passed
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@rhamilto: Jira Issue Verification Checks: Jira Issue OCPBUGS-94168
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-94168 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

Analysis / Root cause:
CVE-2026-13149 — brace-expansion through 5.0.6 is vulnerable to denial of service. The expand() function exhibits exponential-time complexity (O(2^n)) in the number of consecutive non-expanding {} brace groups. A ~90 byte payload can block the calling thread for minutes. The max option does not mitigate this.

The repo carried three vulnerable transitive copies via minimatch: 1.1.12 (via minimatch 3.1.5), 2.1.0 (via minimatch 9.0.9), and 5.0.5 (via minimatch 10.2.5).

Jira: https://redhat.atlassian.net/browse/OCPBUGS-94168

Solution description:
Add per-descriptor yarn resolutions to bump each brace-expansion major line to its patched release:

  • brace-expansion@npm:^1.1.71.1.16 (for minimatch 3.x)
  • brace-expansion@npm:^2.0.22.1.2 (for minimatch 9.x)
  • brace-expansion@npm:^5.0.55.0.7 (for minimatch 10.x)

Each resolution targets a specific descriptor to preserve API compatibility within its major line. A blanket >=1.1.16 resolution was attempted first but broke minimatch 3.x because brace-expansion 5.x has an incompatible API (expand is not a function).

Screenshots / screen recording:
N/A — dependency-only change with no UI impact.

Test setup:
N/A

Test cases:

  • yarn build completes successfully with the updated dependencies.
  • yarn lint passes (verifies eslint-plugin-import's no-extraneous-dependencies rule works with the updated brace-expansion, which was the failure mode of the first attempt).

Browser conformance:

  • Chrome
  • Firefox
  • Safari (or Epiphany on Linux)

N/A — no runtime behavior change.

Additional info:

  • CVSS 5.3 (Medium) — CWE-400, CWE-407
  • Fixed versions: 1.1.16, 2.1.2, 5.0.7

Reviewers and assignees:

Summary by CodeRabbit

  • Chores
  • Updated package resolution settings to ensure compatible versions of required components are used, including keeping protobufjs pinned and adding brace-expansion overrides for more targeted version control.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@rhamilto
rhamilto deleted the OCPBUGS-94168 branch July 23, 2026 19:32
@rhamilto

Copy link
Copy Markdown
Member Author

/jira refresh

@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@rhamilto: Jira Issue OCPBUGS-94168 is in an unrecognized state (MODIFIED) and will not be moved to the MODIFIED state.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants