NO-JIRA: Remove generated plugin manifest JSON schema files

[vojtechszocs]

Analysis / Root cause

We're generating the following files which are not used anymore:

packages/console-dynamic-plugin-sdk/generated/schema/plugin-manifest.cjs
packages/console-dynamic-plugin-sdk/generated/schema/plugin-manifest.json

This JSON schema was used to validate dynamic plugin manifests as part of original Console PluginStore impl.

With #15904 we removed Console fetchPluginManifest and related code in favor of upstream PluginStore impl.

Upstream PluginStore already performs manifest validation via PluginLoader.loadPluginManifest method.

Console already performs additional manifest validation via loaderOptions.transformPluginManifest function.

// public/plugins.ts

export const pluginStore = new PluginStore({
  loaderOptions: {
    // ...
    // Additional validation for Console plugin manifests
    transformPluginManifest: (manifest) => {
      // ...
    },
  },
});

Solution description

Remove generated plugin manifest JSON schema files.

Test setup

Building Console plugin SDK and Console application should work as before.

yarn install
yarn build-plugin-sdk
yarn dev

Summary by CodeRabbit

• Refactor
  • Updated plugin update checks to use the current remote plugin manifest format.
  • Removed the deprecated plugin manifest schema and stopped generating schemas for it.
  • No user-facing functionality changes are expected.

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[coderabbitai]

Walkthrough

The exported ConsolePluginManifestJSON type and its schema generation entry were removed. PollConsoleUpdates now uses RemotePluginManifest for plugin manifest state, fetch results, promise collections, and refs.

Changes

Plugin manifest migration

Layer / File(s)	Summary
Remove plugin manifest schema generation frontend/packages/console-dynamic-plugin-sdk/scripts/generate-schema.ts, frontend/packages/console-dynamic-plugin-sdk/src/schema/plugin-manifest.ts	The exported plugin manifest schema type and its generator configuration are removed.
Migrate polling manifest types frontend/public/components/poll-console-updates.tsx	Plugin manifest state, fetch results, promise casts, and previous-data refs now use RemotePluginManifest.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

• openshift/console#16850: Updates development scripts to run the schema generation step affected by this change.

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	No Ginkgo test titles were added or modified; the PR only removes schema generation and updates a component type, with no test definitions in touched files.
Test Structure And Quality	✅ Passed	PR only changes 3 non-test TypeScript files; no Ginkgo test code was added or modified, so the test-quality check is not applicable.
Microshift Test Compatibility	✅ Passed	No Ginkgo e2e tests were added or modified; the PR only changes schema generation and a UI component, so MicroShift test compatibility is not implicated.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	Diff only changes TS/TSX files; no Ginkgo e2e tests were added, so SNO-specific checks are not applicable.
Topology-Aware Scheduling Compatibility	✅ Passed	Only schema/type cleanup and a type import update changed; no manifests, controllers, affinities, nodeSelectors, or replica logic were added.
Ote Binary Stdout Contract	✅ Passed	The diff only removes schema generation/type code and updates a React component; no new stdout writes were added to process-level entrypoint/setup code.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	No Ginkgo/e2e tests were added or changed; the PR only removes schema code and updates a TS component type.
No-Weak-Crypto	✅ Passed	Touched files only remove schema refs and switch a manifest type; no MD5/SHA1/DES/RC4/ECB, custom crypto, or secret compares appear.
Container-Privileges	✅ Passed	PR only removes a schema type and updates TS typings; no container/K8s manifests or privilege-related security settings are introduced.
No-Sensitive-Data-In-Logs	✅ Passed	Changed files only log schema-generation progress and output filenames; no passwords, tokens, PII, or host/customer data are logged.
Title check	✅ Passed	The title is concise and accurately summarizes the main change.
Description check	✅ Passed	The description covers the root cause, solution, and test setup with specific details, so it is mostly complete.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[logonoff]

/lgtm

[openshift-merge-bot]

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-gcp-console
/test e2e-playwright

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: logonoff, vojtechszocs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• frontend/OWNERS [logonoff,vojtechszocs]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[logonoff]

/label px-approved
/label docs-approved

no impact to runtime
/verified bypass

/retitle NO-JIRA: Remove generated plugin manifest JSON schema files

[openshift-ci-robot]

@logonoff: The verified label has been added.

Details

In response to this:

/label px-approved
/label docs-approved

no impact to runtime
/verified bypass

/retitle NO-JIRA: Remove generated plugin manifest JSON schema files

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@vojtechszocs: This pull request explicitly references no jira issue.

Details

In response to this:

Analysis / Root cause

We're generating the following files which are not used anymore:

packages/console-dynamic-plugin-sdk/generated/schema/plugin-manifest.cjs
packages/console-dynamic-plugin-sdk/generated/schema/plugin-manifest.json

This JSON schema was used to validate dynamic plugin manifests as part of original Console PluginStore impl.

With #15904 we removed Console fetchPluginManifest and related code in favor of upstream PluginStore impl.

Upstream PluginStore already performs manifest validation via PluginLoader.loadPluginManifest method.

Console already performs additional manifest validation via loaderOptions.transformPluginManifest function.

// public/plugins.ts

export const pluginStore = new PluginStore({
 loaderOptions: {
   // ...
   // Additional validation for Console plugin manifests
   transformPluginManifest: (manifest) => {
     // ...
   },
 },
});

Solution description

Remove generated plugin manifest JSON schema files.

Test setup

Building Console plugin SDK and Console application should work as before.

yarn install
yarn build-plugin-sdk
yarn dev

Summary by CodeRabbit

• Refactor
• Updated plugin update checks to use the current remote plugin manifest format.
• Removed the deprecated plugin manifest schema and stopped generating schemas for it.
• No user-facing functionality changes are expected.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.