[release-4.21] OCPBUGS-100328: Fix pod terminal not rendering until resize by openshift-cherrypick-robot · Pull Request #16894 · openshift/console

openshift-cherrypick-robot · 2026-07-31T02:35:47Z

This is an automated cherry-pick of #16892

/assign Leo6Leo

The terminal container starts with 0x0 dimensions and uses setTimeout(0) to call fitAddon.fit() after setting new dimensions via React state. This races with React 18's batched state updates — fit() can fire before the DOM has the correct dimensions, leaving xterm unable to render content until a manual resize event. Replace setTimeout(0) with a ResizeObserver (via PatternFly's getResizeObserver) that fires precisely when the container's actual DOM dimensions change, guaranteeing fit() always sees the correct size. Backport of openshift#16498 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

openshift-merge-bot · 2026-07-31T02:35:49Z

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

coderabbitai · 2026-07-31T02:35:56Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: f59be3e9-c519-4849-b08a-df3d67561180

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

_{Comment @coderabbitai help to get the list of available commands.}

openshift-ci-robot · 2026-07-31T02:36:59Z

@openshift-cherrypick-robot: Jira Issue OCPBUGS-100317 has been cloned as Jira Issue OCPBUGS-100328. Will retitle bug to link to clone.
/retitle [release-4.21] OCPBUGS-100328: Fix pod terminal not rendering until resize

Details

In response to this:

This is an automated cherry-pick of #16892

/assign Leo6Leo

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2026-07-31T02:37:16Z

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-100328, which is invalid:

expected dependent Jira Issue OCPBUGS-100317 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is MODIFIED instead
expected dependent Jira Issue OCPBUGS-100317 to target a version in 4.22.0, but it targets "4.22.z" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is an automated cherry-pick of #16892

/assign Leo6Leo

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

logonoff

This should not affect this release as 4.21 is on react 17 but we can merge this for correctness

openshift-ci · 2026-07-31T03:07:20Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: logonoff, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~frontend/OWNERS~~ [logonoff]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

logonoff · 2026-07-31T03:10:29Z

/label backport-risk-assessed

tmshort · 2026-07-31T13:49:53Z

/retest
/jira refresh

openshift-ci-robot · 2026-07-31T13:49:57Z

@tmshort: This pull request references Jira Issue OCPBUGS-100328, which is invalid:

expected dependent Jira Issue OCPBUGS-100317 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead
expected dependent Jira Issue OCPBUGS-100317 to target a version in 4.22.0, but it targets "4.22.z" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/retest
/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

tmshort · 2026-07-31T13:50:26Z

/jira refresh

openshift-ci-robot · 2026-07-31T13:50:31Z

@tmshort: This pull request references Jira Issue OCPBUGS-100328, which is invalid:

expected dependent Jira Issue OCPBUGS-100317 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2026-07-31T14:14:00Z

@openshift-cherrypick-robot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/okd-scos-images	`4bbc013`	link	true	`/test okd-scos-images`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-cherrypick-robot assigned Leo6Leo Jul 31, 2026

openshift-cherrypick-robot mentioned this pull request Jul 31, 2026

[release-4.22] OCPBUGS-100317: Fix pod terminal not rendering until resize #16892

Merged

6 tasks

openshift-ci Bot changed the title ~~[release-4.21] OCPBUGS-100317: Fix pod terminal not rendering until resize~~ [release-4.21] OCPBUGS-100328: Fix pod terminal not rendering until resize Jul 31, 2026

openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jul 31, 2026

openshift-ci Bot requested review from Leo6Leo and jhadvig July 31, 2026 02:37

openshift-ci Bot added the component/core Related to console core functionality label Jul 31, 2026

logonoff approved these changes Jul 31, 2026

View reviewed changes

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 31, 2026

openshift-ci Bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Jul 31, 2026

openshift-ci Bot assigned sanketpathak Jul 31, 2026

Uh oh!

Conversation

openshift-cherrypick-robot commented Jul 31, 2026

Uh oh!

openshift-merge-bot Bot commented Jul 31, 2026

Uh oh!

coderabbitai Bot commented Jul 31, 2026

Review skipped

Uh oh!

openshift-ci-robot commented Jul 31, 2026

Uh oh!

openshift-ci-robot commented Jul 31, 2026

Uh oh!

logonoff left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci Bot commented Jul 31, 2026

Uh oh!

logonoff commented Jul 31, 2026

Uh oh!

tmshort commented Jul 31, 2026

Uh oh!

openshift-ci-robot commented Jul 31, 2026

Uh oh!

tmshort commented Jul 31, 2026

Uh oh!

openshift-ci-robot commented Jul 31, 2026

Uh oh!

openshift-ci Bot commented Jul 31, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants