Skip to content

[release-4.16] OCPBUGS-70112: Add Cache-Control headers to console responses - #16921

Open
jrangelramos wants to merge 1 commit into
openshift:release-4.16from
jrangelramos:OCPBUGS-70112-cache-control-headers
Open

[release-4.16] OCPBUGS-70112: Add Cache-Control headers to console responses#16921
jrangelramos wants to merge 1 commit into
openshift:release-4.16from
jrangelramos:OCPBUGS-70112-cache-control-headers

Conversation

@jrangelramos

@jrangelramos jrangelramos commented Aug 6, 2026

Copy link
Copy Markdown
Member

Summary

  • Set restrictive cache headers (no-cache, no-store, must-revalidate + Pragma: no-cache) by default on all responses via securityHeadersMiddleware
  • Override with aggressive caching (public, max-age=31536000, immutable) for content-hashed static assets under /static/
  • Remove redundant inner securityHeadersMiddleware wrap on the static handler (the outer mux-level middleware already covers it)

Test plan

  • go build ./cmd/bridge/... compiles cleanly
  • go test ./pkg/server/... — 3 new tests pass:
    • TestSecurityHeadersMiddleware — all 6 headers (4 existing + 2 new)
    • TestStaticCacheHeaders — static handler overrides restrictive defaults
    • TestNonStaticEndpointHasNoCacheHeaders — API endpoints get no-store
  • Manual: browser DevTools Network tab confirms index.html gets no-store, /static/ bundles get max-age=31536000

🤖 Generated with Claude Code

Set restrictive cache headers (no-cache, no-store) by default on all
responses via securityHeadersMiddleware, and override with aggressive
caching (public, max-age=31536000, immutable) for content-hashed static
assets under /static/.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 6, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@jrangelramos: This pull request references Jira Issue OCPBUGS-70112, which is invalid:

  • expected the bug to target the "4.16.z" version, but no target version was set
  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected Jira Issue OCPBUGS-70112 to depend on a bug targeting a version in 4.17.0, 4.17.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Summary

  • Set restrictive cache headers (no-cache, no-store, must-revalidate + Pragma: no-cache) by default on all responses via securityHeadersMiddleware
  • Override with aggressive caching (public, max-age=31536000, immutable) for content-hashed static assets under /static/
  • Remove redundant inner securityHeadersMiddleware wrap on the static handler (the outer mux-level middleware already covers it)

Test plan

  • go build ./cmd/bridge/... compiles cleanly
  • go test ./pkg/server/... — 3 new tests pass:
  • TestSecurityHeadersMiddleware — all 6 headers (4 existing + 2 new)
  • TestStaticCacheHeaders — static handler overrides restrictive defaults
  • TestNonStaticEndpointHasNoCacheHeaders — API endpoints get no-store
  • Manual: browser DevTools Network tab confirms index.html gets no-store, /static/ bundles get max-age=31536000

🤖 Generated with Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai

coderabbitai Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: f7a08bcc-8dda-4dac-96ab-4198386fe218

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci
openshift-ci Bot requested review from florkbr and jhadvig August 6, 2026 17:25
@openshift-ci openshift-ci Bot added the component/backend Related to backend label Aug 6, 2026
@openshift-ci

openshift-ci Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jrangelramos
Once this PR has been reviewed and has the lgtm label, please assign florkbr for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci

openshift-ci Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

@jrangelramos: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/backend fa53283 link true /test backend

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component/backend Related to backend jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants