Skip to content

OCPBUGS-14473: Guard against undefined data in dashboard charts #16952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ericahinkleRH wants to merge 1 commit into
base: main
Choose a base branch
from
+19 −16
Open

OCPBUGS-14473: Guard against undefined data in dashboard charts #16952

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 15 additions & 12 deletions ...end/packages/console-shared/src/components/dashboard/utilization-card/UtilizationItem.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,23 +70,26 @@ export const MultilineUtilizationItem = memo<MultilineUtilizationItemProps>(
}, [maxDate, updateEndDate]);

const mapTranslatedData = (originalData: DataPoint[][]) => {
if (!originalData || originalData.length === 0 || originalData[0].length === 0)
return originalData;
if (!originalData || originalData.length === 0) return originalData;
const translatedData = [];

for (const query of originalData) {
const currData = [];
const desc = query[0].description;
for (const item of query) {
if (desc === 'in') {
currData.push({ ...item, description: t('in') });
} else if (desc === 'out') {
currData.push({ ...item, description: t('out') });
} else {
currData.push(item);
if (!query || query.length === 0) {
translatedData.push(query);
} else {
const currData = [];
const desc = query[0].description;
for (const item of query) {
if (desc === 'in') {
currData.push({ ...item, description: t('in') });
} else if (desc === 'out') {
currData.push({ ...item, description: t('out') });
} else {
currData.push(item);
}
}
translatedData.push(currData);
}
translatedData.push(currData);
}
return translatedData;
};
Expand Down
8 changes: 4 additions & 4 deletions frontend/public/components/graphs/area.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,9 +112,9 @@ export const AreaChart: FC<AreaChartProps> = ({
const container = useMemo(() => {
if (multiLine) {
const legendData = processedData.map((d) => ({
childName: d[0].description,
name: d[0].description,
symbol: d[0].symbol,
childName: d[0]?.description,
name: d[0]?.description,
symbol: d[0]?.symbol,
}));
return (
<CursorVoronoiContainer
Expand All @@ -127,7 +127,7 @@ export const AreaChart: FC<AreaChartProps> = ({
stack={showAllTooltip}
legendData={legendData}
getLabel={getLabel}
formatDate={(d) => formatDate(d[0].x)}
formatDate={(d) => formatDate(d[0]?.x)}
mainDataName={mainDataName}
/>
}
Expand Down