[release-4.16] OCPBUGS-114417: Prevent binary secret data corruption when editing by TheRealJon · Pull Request #17101 · openshift/console

TheRealJon · 2026-08-26T20:47:05Z

Manual backport of #16879

When editing secrets containing binary data (JAR, JCEKS, etc), the binary values were being corrupted by decoding base64 as UTF-8 text, which inserts replacement characters for non-printable bytes. Fixed by: - Pass base64 data directly to DroppableFileInput for binary entries - Add isBase64Input prop to properly handle base64-encoded input - Preserve original binary values when form updates to prevent corruption - Use useMemo instead of useState for derived binaryData value - Use immutable reducer pattern to merge binary data Added Cypress test to verify editing text fields doesn't corrupt binary data in the same secret. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

openshift-merge-bot · 2026-08-26T20:47:07Z

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

openshift-ci-robot · 2026-08-26T20:47:11Z

@TheRealJon: This pull request references Jira Issue OCPBUGS-114417, which is invalid:

expected Jira Issue OCPBUGS-114417 to depend on a bug targeting a version in 4.17.0, 4.17.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Manual backport of #16879

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

coderabbitai · 2026-08-26T20:47:12Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: d1ba12c7-4404-40cd-8d28-18ea42a322c7

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

_{Comment @coderabbitai help to get the list of available commands.}

TheRealJon · 2026-08-27T13:38:27Z

/retest

TheRealJon · 2026-08-27T13:39:28Z

/jira refresh

openshift-ci-robot · 2026-08-27T13:39:36Z

@TheRealJon: This pull request references Jira Issue OCPBUGS-114417, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.16.z) matches configured target version for branch (4.16.z)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
release note text is set and does not match the template
dependent bug Jira Issue OCPBUGS-100172 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
dependent Jira Issue OCPBUGS-100172 targets the "4.17.z" version, which is one of the valid target versions: 4.17.0, 4.17.z
bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (yapei@redhat.com), skipping review request.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

TheRealJon · 2026-08-27T13:55:13Z

/retest

vikram-raj

/lgtm

Leo6Leo · 2026-08-27T14:37:33Z

/verified by CI
/label backport-risk-assessed

openshift-ci-robot · 2026-08-27T14:37:45Z

@Leo6Leo: This PR has been marked as verified by CI.

Details

In response to this:

/verified by CI
/label backport-risk-assessed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

logonoff · 2026-08-27T14:37:47Z

@@ -1,5 +1,3 @@
-import 'cypress-file-upload';


You can prob remove this dep

openshift-merge-bot · 2026-08-27T14:39:00Z

Scheduling required tests:
/test e2e-gcp-console

openshift-ci · 2026-08-27T14:39:19Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: TheRealJon, vikram-raj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~frontend/OWNERS~~ [TheRealJon,vikram-raj]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-merge-bot · 2026-08-27T18:14:55Z

/retest-required

Remaining retests: 0 against base HEAD a6962c0 and 2 for PR HEAD 4fea3b5 in total

openshift-merge-bot · 2026-08-29T14:08:58Z

/retest-required

Remaining retests: 0 against base HEAD d10adfe and 1 for PR HEAD 4fea3b5 in total

openshift-ci · 2026-08-29T18:56:21Z

@TheRealJon: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci-robot · 2026-08-29T19:01:39Z

@TheRealJon: Jira Issue Verification Checks: Jira Issue OCPBUGS-114417
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-114417 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

Manual backport of #16879

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Aug 26, 2026

openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Aug 26, 2026

openshift-ci Bot requested review from Leo6Leo and rhamilto August 26, 2026 20:47

openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 27, 2026

vikram-raj reviewed Aug 27, 2026

View reviewed changes

openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Aug 27, 2026

logonoff reviewed Aug 27, 2026

View reviewed changes

openshift-ci Bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Aug 27, 2026

openshift-ci Bot assigned vikram-raj Aug 27, 2026

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 27, 2026

openshift-merge-bot Bot merged commit 5444707 into openshift:release-4.16 Aug 29, 2026
7 checks passed

Uh oh!

Conversation

TheRealJon commented Aug 26, 2026

Uh oh!

openshift-merge-bot Bot commented Aug 26, 2026

Uh oh!

openshift-ci-robot commented Aug 26, 2026

Uh oh!

coderabbitai Bot commented Aug 26, 2026

Review skipped

Uh oh!

TheRealJon commented Aug 27, 2026

Uh oh!

TheRealJon commented Aug 27, 2026

Uh oh!

openshift-ci-robot commented Aug 27, 2026

Uh oh!

TheRealJon commented Aug 27, 2026

Uh oh!

vikram-raj left a comment

Choose a reason for hiding this comment

Uh oh!

Leo6Leo commented Aug 27, 2026

Uh oh!

openshift-ci-robot commented Aug 27, 2026

Uh oh!

logonoff Aug 27, 2026

Choose a reason for hiding this comment

Uh oh!

openshift-merge-bot Bot commented Aug 27, 2026

Uh oh!

openshift-ci Bot commented Aug 27, 2026

Uh oh!

openshift-merge-bot Bot commented Aug 27, 2026

Uh oh!

openshift-merge-bot Bot commented Aug 29, 2026

Uh oh!

openshift-ci Bot commented Aug 29, 2026

Uh oh!

Uh oh!

openshift-ci-robot commented Aug 29, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants