NO-JIRA: [release-4.20] Enable ReadWriteOncePod for Cinder CSI - #17107
NO-JIRA: [release-4.20] Enable ReadWriteOncePod for Cinder CSI#17107kchawlani19 wants to merge 2 commits into
Conversation
The Create PVC form greys out RWOP for cinder.csi.openstack.org because the static provisioner map listed only ReadWriteOnce. YAML already works on OpenStack 4.20; add RWOP for Filesystem and Block, drop the duplicate in-tree Cinder entry, and cover the mapping with unit tests. Backport of openshift#16870. Related to openshift#16866.
|
Pipeline controller notification For optional jobs, comment This repository is configured in: LGTM mode |
|
@kchawlani19: This pull request explicitly references no jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Match the main-branch tests so jest/valid-title does not fail if this branch picks up the newer ESLint rule.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: kchawlani19 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@kchawlani19: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Analysis / Root cause:
On OpenShift 4.20, the Create PersistentVolumeClaim form greys out ReadWriteOncePod for Cinder CSI. Allowed access modes come from a static map in
frontend/public/components/storage/shared.ts;cinder.csi.openstack.orglisted onlyReadWriteOnce. Creating the same PVC via YAML works. Reported in #16866 against 4.20 IPI on OpenStack 18.Solution description:
Backport of #16870 plus regression tests:
cinder.csi.openstack.org: addReadWriteOncePodfor Filesystem and Blockkubernetes.io/cinder: remove duplicateReadWriteOncePodentriesScreenshots / screen recording:
N/A (access-mode dropdown option enablement)
Test setup:
OpenShift 4.20 on OpenStack with a StorageClass whose provisioner is
cinder.csi.openstack.org.Test cases:
Browser conformance:
Additional info:
Related to #16866
Backport of #16870
Tests on main: #17105
4.22 backport: #17106
Reviewers and assignees:
/assign spadgett