Skip to content

Improve 'unauthenticated' error message - #2850

Merged
openshift-merge-robot merged 1 commit into
openshift:masterfrom
benjaminapetersen:logging/improvements/unauthenticated-user
Nov 19, 2019
Merged

Improve 'unauthenticated' error message#2850
openshift-merge-robot merged 1 commit into
openshift:masterfrom
benjaminapetersen:logging/improvements/unauthenticated-user

Conversation

@benjaminapetersen

Copy link
Copy Markdown
Contributor

Improve 'unauthenticated' error message to indicate the problem is named cookie.

@spadgett

@openshift-ci-robot openshift-ci-robot added component/backend Related to backend size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 26, 2019
Comment thread pkg/auth/auth_openshift.go Outdated
@benjaminapetersen
benjaminapetersen force-pushed the logging/improvements/unauthenticated-user branch from 5204e33 to 4784120 Compare October 2, 2019 18:45
@benjaminapetersen

Copy link
Copy Markdown
Contributor Author

@spadgett sorry, habit with \n on the errorf, updated!

@enj

enj commented Oct 16, 2019

Copy link
Copy Markdown
Contributor

/uncc

@stlaz @sttts @mfojtik

@openshift-ci-robot
openshift-ci-robot removed the request for review from enj October 16, 2019 15:08
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@benjaminapetersen: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws-console-olm 4784120 link /test e2e-aws-console-olm
ci/prow/e2e-aws-console 4784120 link /test e2e-aws-console
ci/prow/e2e-gcp 4784120 link /test e2e-gcp

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@benjaminapetersen

Copy link
Copy Markdown
Contributor Author

/retest

@spadgett spadgett left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 19, 2019
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: benjaminapetersen, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spadgett

Copy link
Copy Markdown
Member

/override ci/prow/e2e-gcp
test has since been removed from the repo

@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@spadgett: Overrode contexts on behalf of spadgett: ci/prow/e2e-gcp

Details

In response to this:

/override ci/prow/e2e-gcp
test has since been removed from the repo

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot
openshift-merge-robot merged commit 661a18f into openshift:master Nov 19, 2019
@spadgett spadgett added this to the v4.3 milestone Nov 22, 2019
@benjaminapetersen
benjaminapetersen deleted the logging/improvements/unauthenticated-user branch November 25, 2019 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. component/backend Related to backend lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants