Skip to content

Ensure we don't allow invalid urls as source code links - #2875

Merged
openshift-merge-robot merged 1 commit into
openshift:masterfrom
andrewballantyne:only-url-source-links
Oct 1, 2019
Merged

Ensure we don't allow invalid urls as source code links#2875
openshift-merge-robot merged 1 commit into
openshift:masterfrom
andrewballantyne:only-url-source-links

Conversation

@andrewballantyne

@andrewballantyne andrewballantyne commented Sep 30, 2019

Copy link
Copy Markdown
Contributor

Resolves: https://jira.coreos.com/browse/ODC-1930

Screen Shot 2019-09-30 at 7 35 50 PM Screen Shot 2019-09-30 at 7 35 58 PM

Tests:

 PASS  packages/dev-console/src/components/import/__tests__/render-utils.spec.ts
  Ensure render utils works
    Ensure we do not get route decorator icons for invalid urls
      ✓ expect route decoration icon to give nothing for bad urls (2ms)
      ✓ expect no route when using inline javascript (1ms)
      ✓ expect no route when giving empty values
    Ensure we get expected icons with valid HTTPS links
      ✓ expect bitbucket icon
      ✓ expect github icon
      ✓ expect gitlab icon (1ms)
      ✓ expect git-alt icon when not a supported site
    Ensure we get expected icons with valid git SSH links
      ✓ expect bitbucket icon
      ✓ expect github icon (1ms)
      ✓ expect gitlab icon

@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. component/dev-console Related to dev-console labels Sep 30, 2019
@gijohn

gijohn commented Oct 1, 2019

Copy link
Copy Markdown
Contributor

/retest
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 1, 2019
@rohitkrai03

Copy link
Copy Markdown
Contributor

/test e2e-aws-console

@rohitkrai03

Copy link
Copy Markdown
Contributor

/approve

@openshift-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewballantyne, gijohn, rohitkrai03

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 1, 2019
@openshift-merge-robot
openshift-merge-robot merged commit 722f16c into openshift:master Oct 1, 2019
@spadgett spadgett added this to the v4.3 milestone Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. component/dev-console Related to dev-console lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants