Skip to content

Add descriptor reference doc - #2962

Merged
openshift-merge-robot merged 1 commit into
openshift:masterfrom
tlwu2013:reference-doc
Nov 11, 2019
Merged

Add descriptor reference doc#2962
openshift-merge-robot merged 1 commit into
openshift:masterfrom
tlwu2013:reference-doc

Conversation

@tlwu2013

@tlwu2013 tlwu2013 commented Oct 12, 2019

Copy link
Copy Markdown
Contributor

Initial doc for descriptor reference with code snippet and example screenshots.

@openshift-ci-robot

openshift-ci-robot commented Oct 12, 2019

Copy link
Copy Markdown
Contributor

Hi @tlwu2013. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 12, 2019
@openshift-ci-robot openshift-ci-robot added the component/olm Related to OLM label Oct 12, 2019
@tlwu2013
tlwu2013 force-pushed the reference-doc branch 2 times, most recently from af6ab5c to 3a423be Compare October 12, 2019 00:54
@tlwu2013

tlwu2013 commented Oct 12, 2019

Copy link
Copy Markdown
Contributor Author

cc @alimobrem This is the markdown version of the descriptor reference.
Do we need to include those work-in-progress views in the reference?

@tlwu2013

tlwu2013 commented Oct 28, 2019

Copy link
Copy Markdown
Contributor Author

Hey @spadgett and @alecmerdler , can you guys help review if this doc is good to merge?
Much appreciated!

alecmerdler
alecmerdler approved these changes Oct 29, 2019
View reviewed changes

@alecmerdler alecmerdler left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job!

@tlwu2013
tlwu2013 requested a review from alecmerdler October 29, 2019 21:43
@alecmerdler

alecmerdler commented Oct 30, 2019

Copy link
Copy Markdown
Contributor

/ok-to-test

@openshift-ci-robot openshift-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 30, 2019
alecmerdler
alecmerdler approved these changes Oct 30, 2019
View reviewed changes

@alecmerdler alecmerdler left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 30, 2019
@spadgett spadgett added this to the v4.3 milestone Oct 31, 2019
@spadgett

spadgett commented Nov 11, 2019

Copy link
Copy Markdown
Member

/approve

docs only

@openshift-ci-robot

openshift-ci-robot commented Nov 11, 2019

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alecmerdler, spadgett, tlwu2013

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spadgett

spadgett commented Nov 11, 2019

Copy link
Copy Markdown
Member

Thanks @tlwu2013 !

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 11, 2019
@spadgett

spadgett commented Nov 11, 2019

Copy link
Copy Markdown
Member

/refresh

@openshift-merge-robot
openshift-merge-robot merged commit 4e78ca7 into openshift:master Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@spadgett spadgett Awaiting requested review from spadgett
1 more reviewer
@alecmerdler alecmerdler alecmerdler approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@alecmerdler alecmerdler

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. component/olm Related to OLM lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Milestone

v4.3

Development

Successfully merging this pull request may close these issues.

5 participants

@tlwu2013 @openshift-ci-robot @alecmerdler @spadgett @openshift-merge-robot