feat(pipeline-logs):Download Pipeline Logs - #2987
Conversation
openshift-ci-robot
added
size/M
There was a problem hiding this comment.
This function should moved to the class instead of created on render since this is a class component.
There was a problem hiding this comment.
Moved to a class member
There was a problem hiding this comment.
This is for trimming the first line which contains the TaskName. The Taskname is there in the filename as well. Hence removing this.
Added a comment in the code for same and now using substring to obtain the desired log content
There was a problem hiding this comment.
Interesting idea! One issue is that we can still be loading the data and therefore the logs will be downloaded w/ missing data. But I see that resource-log suffers the same fate. Just less chance of error due to a single stream. So I guess for now this is ok.
91df3d6 to
1e6f10d
Compare
There was a problem hiding this comment.
Unnecessary when using this notation downloadLogs = () => {
There was a problem hiding this comment.
moved that out
1e6f10d to
ac176be
Compare
|
/retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinandan13jan, christianvogt The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
6 participants
https://jira.coreos.com/browse/ODC-844
