Skip to content

Fix: Deploying Port-less Container Image Fails - #3028

Merged
openshift-merge-robot merged 1 commit into
openshift:masterfrom
gijohn:odc2060_deploy_port_fix
Oct 24, 2019
Merged

Fix: Deploying Port-less Container Image Fails#3028
openshift-merge-robot merged 1 commit into
openshift:masterfrom
gijohn:odc2060_deploy_port_fix

Conversation

@gijohn

@gijohn gijohn commented Oct 21, 2019

Copy link
Copy Markdown
Contributor

@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. component/dev-console Related to dev-console labels Oct 21, 2019
@gijohn

gijohn commented Oct 21, 2019

Copy link
Copy Markdown
Contributor Author

/kind bug
/cc @andrewballantyne @vikram-raj
/assign @rohitkrai03 @christianvogt

@openshift-ci-robot openshift-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Oct 21, 2019
@gijohn

gijohn commented Oct 21, 2019

Copy link
Copy Markdown
Contributor Author

/retest

debsmita1
debsmita1 suggested changes Oct 21, 2019
View reviewed changes
Comment thread frontend/packages/dev-console/src/utils/shared-submit-utils.ts Outdated
@andrewballantyne

andrewballantyne commented Oct 21, 2019

Copy link
Copy Markdown
Contributor

LGTM - Tested it and it seems to have nicely solved the issue.

@gijohn
gijohn force-pushed the odc2060_deploy_port_fix branch from d416145 to 26e0fb4 Compare October 22, 2019 05:20
@gijohn

gijohn commented Oct 22, 2019

Copy link
Copy Markdown
Contributor Author

/test e2e-aws-console-olm

@andrewballantyne

andrewballantyne commented Oct 22, 2019

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 22, 2019
@christianvogt

christianvogt commented Oct 22, 2019

Copy link
Copy Markdown
Contributor

@gijohn please add a unit test

@gijohn
gijohn force-pushed the odc2060_deploy_port_fix branch from 26e0fb4 to 88883d4 Compare October 23, 2019 06:51
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Oct 23, 2019
@gijohn

gijohn commented Oct 23, 2019

Copy link
Copy Markdown
Contributor Author

@gijohn please add a unit test

@christianvogt I have added another validation. Previously the test was written for a wrong logic. I have corrected that too.

@christianvogt

christianvogt commented Oct 23, 2019

Copy link
Copy Markdown
Contributor

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 23, 2019
@openshift-ci-robot

openshift-ci-robot commented Oct 23, 2019

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewballantyne, christianvogt, gijohn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 23, 2019
@openshift-bot

openshift-bot commented Oct 23, 2019

Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot

openshift-bot commented Oct 24, 2019

Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

openshift-bot commented Oct 24, 2019

Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot
openshift-merge-robot merged commit 2e07ae9 into openshift:master Oct 24, 2019
@spadgett spadgett added this to the v4.3 milestone Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@karthikjeeyar karthikjeeyar Awaiting requested review from karthikjeeyar
@nemesis09 nemesis09 Awaiting requested review from nemesis09
@andrewballantyne andrewballantyne Awaiting requested review from andrewballantyne
@vikram-raj vikram-raj Awaiting requested review from vikram-raj
2 more reviewers
@christianvogt christianvogt christianvogt left review comments
@debsmita1 debsmita1 debsmita1 requested changes
Reviewers whose approvals may not affect merge requirements

Assignees

@rohitkrai03 rohitkrai03

@andrewballantyne andrewballantyne

@christianvogt christianvogt

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. component/dev-console Related to dev-console kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

v4.3

Development

Successfully merging this pull request may close these issues.

9 participants

@gijohn @andrewballantyne @christianvogt @openshift-ci-robot @openshift-bot @debsmita1 @spadgett @rohitkrai03 @openshift-merge-robot