Skip to content

Fix typo in name of cluster-thanos flag error display name - #3044

Merged
openshift-merge-robot merged 1 commit into
openshift:masterfrom
yaacov:fix-typo-in-thanos-flag-name
Oct 28, 2019
Merged

Fix typo in name of cluster-thanos flag error display name#3044
openshift-merge-robot merged 1 commit into
openshift:masterfrom
yaacov:fix-typo-in-thanos-flag-name

Conversation

@yaacov

@yaacov yaacov commented Oct 22, 2019

Copy link
Copy Markdown
Member

When k8s-mode-off-cluster-thanos flag is invalid the display error is wrong.

cc:// @irosenzw

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 22, 2019
@yaacov

yaacov commented Oct 22, 2019

Copy link
Copy Markdown
Member Author

/test e2e-aws-console-olm
/test e2e-gcp-console

@yaacov

yaacov commented Oct 22, 2019

Copy link
Copy Markdown
Member Author

/test e2e-aws-console-olm

3 similar comments
@yaacov

yaacov commented Oct 22, 2019

Copy link
Copy Markdown
Member Author

/test e2e-aws-console-olm

@yaacov

yaacov commented Oct 22, 2019

Copy link
Copy Markdown
Member Author

/test e2e-aws-console-olm

@yaacov

yaacov commented Oct 23, 2019

Copy link
Copy Markdown
Member Author

/test e2e-aws-console-olm

@yaacov

yaacov commented Oct 23, 2019

Copy link
Copy Markdown
Member Author

ref: #3047

@yaacov

yaacov commented Oct 28, 2019

Copy link
Copy Markdown
Member Author

@spadgett PTAL

@spadgett spadgett left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 28, 2019
@spadgett spadgett added this to the v4.3 milestone Oct 28, 2019
@spadgett

Copy link
Copy Markdown
Member

/kind bug

@openshift-ci-robot openshift-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Oct 28, 2019
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: spadgett, yaacov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 28, 2019
@yaacov

yaacov commented Oct 28, 2019

Copy link
Copy Markdown
Member Author

/test e2e-gcp-console

1 similar comment
@yaacov

yaacov commented Oct 28, 2019

Copy link
Copy Markdown
Member Author

/test e2e-gcp-console

@openshift-bot

Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@yaacov

yaacov commented Oct 28, 2019

Copy link
Copy Markdown
Member Author

/test e2e-gcp-console

@spadgett

Copy link
Copy Markdown
Member

/retest

1 similar comment
@spadgett

Copy link
Copy Markdown
Member

/retest

@openshift-merge-robot
openshift-merge-robot merged commit b4ee147 into openshift:master Oct 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants