Skip to content

Show restricted access on project access page to users having no access to Role Bindings - #3055

Merged
openshift-merge-robot merged 1 commit into
openshift:masterfrom
debsmita1:handle-view
Oct 24, 2019
Merged

Show restricted access on project access page to users having no access to Role Bindings#3055
openshift-merge-robot merged 1 commit into
openshift:masterfrom
debsmita1:handle-view

Conversation

@debsmita1

@debsmita1 debsmita1 commented Oct 22, 2019

Copy link
Copy Markdown
Contributor

This PR shows restricted access alert on the Project Access page to the users having no access to Role Bindings

View_role

Jira task : https://jira.coreos.com/browse/ODC-1967

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 22, 2019
@openshift-ci-robot openshift-ci-robot added the component/dev-console Related to dev-console label Oct 22, 2019
@debsmita1 debsmita1 mentioned this pull request Oct 22, 2019
Closed
@debsmita1

debsmita1 commented Oct 22, 2019

Copy link
Copy Markdown
Contributor Author

/assign @christianvogt
cc @serenamarie125

@debsmita1

debsmita1 commented Oct 22, 2019

Copy link
Copy Markdown
Contributor Author

/test e2e-gcp

@christianvogt

christianvogt commented Oct 22, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

@debsmita1 your gif shows some padding issues in the project access page.

@serenamarie125

serenamarie125 commented Oct 22, 2019

Copy link
Copy Markdown
Contributor

I see the same thing re: padding ... the role binding has padding to the left of the inline notification, but the project access page has none.

Otherwise looks great!

@debsmita1

debsmita1 commented Oct 23, 2019

Copy link
Copy Markdown
Contributor Author

Updated Project Access Page:
Project_Access

I included the Page Title & description with the Restricted Access Alert by referring to the Role Bindings page
Role_Binding

@christianvogt @serenamarie125 Please let me know if this looks okay

@debsmita1

debsmita1 commented Oct 23, 2019

Copy link
Copy Markdown
Contributor Author

/test e2e-gcp-console

1 similar comment
@debsmita1

debsmita1 commented Oct 23, 2019

Copy link
Copy Markdown
Contributor Author

/test e2e-gcp-console

@christianvogt

christianvogt commented Oct 23, 2019

Copy link
Copy Markdown
Contributor

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 23, 2019
@openshift-ci-robot

openshift-ci-robot commented Oct 23, 2019

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christianvogt, debsmita1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 23, 2019
@debsmita1

debsmita1 commented Oct 23, 2019

Copy link
Copy Markdown
Contributor Author

/test e2e-gcp-console

1 similar comment
@debsmita1

debsmita1 commented Oct 24, 2019

Copy link
Copy Markdown
Contributor Author

/test e2e-gcp-console

@openshift-merge-robot
openshift-merge-robot merged commit 0a6d9ee into openshift:master Oct 24, 2019
@spadgett spadgett added this to the v4.3 milestone Oct 24, 2019
@debsmita1

debsmita1 commented Jun 30, 2020

Copy link
Copy Markdown
Contributor Author

/kind feature

@openshift-ci-robot openshift-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joshuawilson joshuawilson Awaiting requested review from joshuawilson
@karthikjeeyar karthikjeeyar Awaiting requested review from karthikjeeyar

Assignees

@christianvogt christianvogt

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. component/dev-console Related to dev-console kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

v4.3

Development

Successfully merging this pull request may close these issues.

6 participants

@debsmita1 @christianvogt @serenamarie125 @openshift-ci-robot @spadgett @openshift-merge-robot