Skip to content

kubevirt: Add filter for v2v conversion events - #3068

Merged
openshift-merge-robot merged 1 commit into
openshift:masterfrom
mareklibra:vmEvents.v2v.conversion
Oct 31, 2019
Merged

kubevirt: Add filter for v2v conversion events#3068
openshift-merge-robot merged 1 commit into
openshift:masterfrom
mareklibra:vmEvents.v2v.conversion

Conversation

@mareklibra

@mareklibra mareklibra commented Oct 23, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

The Events tab newly includes v2v conversion pod events.

For performance reasons, the matching is done via conversion pod name instead of ownerReference. It would be costly to fetch all the required data (means list of pods in a namespace) and useless in majority of cases. Conflicts can appear in rare corner cases when the user starts conversion, deletes the VM and starts it again for the same VM name. In that case events of terminated pods can leak to the VM Events list.

This can be easily fixed if any other reason to fetch the pods within VM Events tab appears.

Depends on:

Will be rebased once the dependencies above get merged.

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. component/kubevirt Related to kubevirt-plugin size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 23, 2019
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 23, 2019
@mareklibra

mareklibra commented Oct 24, 2019

Copy link
Copy Markdown
Contributor Author

Rebased

@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 24, 2019
@mareklibra mareklibra changed the title WIP kubevirt: Add filter for v2v conversion events kubevirt: Add filter for v2v conversion events Oct 30, 2019
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 30, 2019
@rawagner

rawagner commented Oct 30, 2019

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 30, 2019
@openshift-ci-robot

openshift-ci-robot commented Oct 30, 2019

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mareklibra, rawagner

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot

openshift-bot commented Oct 30, 2019

Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

9 similar comments
@openshift-bot

openshift-bot commented Oct 30, 2019

Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

openshift-bot commented Oct 30, 2019

Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

openshift-bot commented Oct 30, 2019

Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

openshift-bot commented Oct 31, 2019

Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

openshift-bot commented Oct 31, 2019

Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

openshift-bot commented Oct 31, 2019

Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

openshift-bot commented Oct 31, 2019

Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

openshift-bot commented Oct 31, 2019

Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

openshift-bot commented Oct 31, 2019

Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot
openshift-merge-robot merged commit c686b12 into openshift:master Oct 31, 2019
@spadgett spadgett added this to the v4.3 milestone Oct 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jelkosz jelkosz Awaiting requested review from jelkosz
@rawagner rawagner Awaiting requested review from rawagner

Assignees

@rawagner rawagner

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. component/kubevirt Related to kubevirt-plugin lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

v4.3

Development

Successfully merging this pull request may close these issues.

6 participants

@mareklibra @rawagner @openshift-ci-robot @openshift-bot @spadgett @openshift-merge-robot