Skip to content

Remove Capacity and Top Consumers card - #3102

Merged
openshift-merge-robot merged 1 commit into
openshift:masterfrom
rawagner:4.3-remove-cards
Oct 30, 2019
Merged

Remove Capacity and Top Consumers card#3102
openshift-merge-robot merged 1 commit into
openshift:masterfrom
rawagner:4.3-remove-cards

Conversation

@rawagner

@rawagner rawagner commented Oct 25, 2019

Copy link
Copy Markdown
Contributor

No description provided.

@openshift-ci-robot openshift-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. component/ceph Related to ceph-storage-plugin component/core Related to console core functionality component/dashboard Related to dashboard component/sdk Related to console-plugin-sdk component/shared Related to console-shared labels Oct 25, 2019
@rawagner
rawagner force-pushed the 4.3-remove-cards branch 2 times, most recently from 668695c to c2bda2f Compare October 29, 2019 08:48
@rawagner rawagner mentioned this pull request Oct 29, 2019
Merged
vojtechszocs
vojtechszocs reviewed Oct 29, 2019
View reviewed changes
Comment thread frontend/public/components/utils/units.js Outdated

@vojtechszocs vojtechszocs Oct 29, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the exponentiation operator which is semantically equivalent to Math.pow.

Nit: I'd put the expression 1000 ** 3 in braces to improve readability.

@rawagner rawagner Oct 29, 2019

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eslint has a different opinion so I cannot add braces :)

Rebased

@vojtechszocs vojtechszocs Oct 29, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, ESLint 😃

vojtechszocs
vojtechszocs approved these changes Oct 29, 2019
View reviewed changes

@vojtechszocs vojtechszocs left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 29, 2019
@openshift-bot

openshift-bot commented Oct 29, 2019

Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot

openshift-bot commented Oct 29, 2019

Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

openshift-bot commented Oct 30, 2019

Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@kyoto

kyoto commented Oct 30, 2019

Copy link
Copy Markdown
Member

/retest

6 similar comments
@rawagner

rawagner commented Oct 30, 2019

Copy link
Copy Markdown
Contributor Author

/retest

@rawagner

rawagner commented Oct 30, 2019

Copy link
Copy Markdown
Contributor Author

/retest

@rawagner

rawagner commented Oct 30, 2019

Copy link
Copy Markdown
Contributor Author

/retest

@jelkosz

jelkosz commented Oct 30, 2019

Copy link
Copy Markdown

/retest

@rawagner

rawagner commented Oct 30, 2019

Copy link
Copy Markdown
Contributor Author

/retest

@jelkosz

jelkosz commented Oct 30, 2019

Copy link
Copy Markdown

/retest

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Oct 30, 2019
@jelkosz

jelkosz commented Oct 30, 2019

Copy link
Copy Markdown

Just rebased, adding lgtm back.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 30, 2019
@openshift-ci-robot

openshift-ci-robot commented Oct 30, 2019

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jelkosz, rawagner, vojtechszocs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot
openshift-merge-robot merged commit d2b9dc6 into openshift:master Oct 30, 2019
@spadgett spadgett added this to the v4.3 milestone Oct 31, 2019
@fmartingr fmartingr mentioned this pull request Jul 15, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@afreen23 afreen23 Awaiting requested review from afreen23
@andybraren andybraren Awaiting requested review from andybraren
1 more reviewer
@vojtechszocs vojtechszocs vojtechszocs approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@vojtechszocs vojtechszocs

@jelkosz jelkosz

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. component/ceph Related to ceph-storage-plugin component/core Related to console core functionality component/dashboard Related to dashboard component/sdk Related to console-plugin-sdk component/shared Related to console-shared lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Milestone

v4.3

Development

Successfully merging this pull request may close these issues.

8 participants

@rawagner @openshift-bot @kyoto @jelkosz @openshift-ci-robot @vojtechszocs @spadgett @openshift-merge-robot