Skip to content

dashboards: Fix padding in OCS buckets card - #3120

Merged
openshift-merge-robot merged 1 commit into
openshift:masterfrom
spadgett:buckets-card-padding
Nov 2, 2019
Merged

dashboards: Fix padding in OCS buckets card#3120
openshift-merge-robot merged 1 commit into
openshift:masterfrom
spadgett:buckets-card-padding

Conversation

@spadgett

Copy link
Copy Markdown
Member

/cc @rhamilto @cloudbehl @rawagner

Fixes this bug:

Dashboards · OKD 2019-10-28 10-34-38

@openshift-ci-robot openshift-ci-robot added component/noobaa Related to noobaa-storage-plugin size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 28, 2019
@spadgett

Copy link
Copy Markdown
Member Author

/retest

@rhamilto rhamilto left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 28, 2019
@spadgett spadgett added this to the v4.3 milestone Oct 28, 2019
@spadgett

Copy link
Copy Markdown
Member Author

/kind bug

@openshift-ci-robot openshift-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Oct 28, 2019
@spadgett

Copy link
Copy Markdown
Member Author

/retest

@openshift-bot

Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot

Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@spadgett

Copy link
Copy Markdown
Member Author

/lgtm cancel
needs rebase

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Oct 29, 2019
@afreen23

Copy link
Copy Markdown

@spadgett the change needs to be in resource providers too.

return <div className="co-dashboard-card__body--no-padding">{body || children}</div>;

return <>{body || children}</>;

Thanks for the fix!

@spadgett
spadgett force-pushed the buckets-card-padding branch from 5d2e08c to ab4e3d2 Compare November 1, 2019 17:49
@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 1, 2019
@spadgett

spadgett commented Nov 1, 2019

Copy link
Copy Markdown
Member Author

rebased and fixed the resource providers card

@rhamilto

rhamilto commented Nov 1, 2019

Copy link
Copy Markdown
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 1, 2019
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhamilto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spadgett

spadgett commented Nov 1, 2019

Copy link
Copy Markdown
Member Author

/retest

openshift-merge-robot added a commit that referenced this pull request Nov 2, 2019
dashboards: Fix padding in OCS buckets card
@openshift-merge-robot
openshift-merge-robot merged commit 3049aeb into openshift:master Nov 2, 2019
@openshift-merge-robot
openshift-merge-robot merged commit ab4e3d2 into openshift:master Nov 2, 2019
@spadgett
spadgett deleted the buckets-card-padding branch November 2, 2019 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. component/noobaa Related to noobaa-storage-plugin kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants