Skip to content

fixes issue with invalid props for eventsource and updates spec - #3243

Merged
openshift-merge-robot merged 1 commit into
openshift:masterfrom
invincibleJai:fix-event-soure-camel
Nov 8, 2019
Merged

fixes issue with invalid props for eventsource and updates spec#3243
openshift-merge-robot merged 1 commit into
openshift:masterfrom
invincibleJai:fix-event-soure-camel

Conversation

@invincibleJai

@invincibleJai invincibleJai commented Nov 5, 2019

Copy link
Copy Markdown
Member
  • fixes issue with invalid props for eventsource and updates spec

Tracks: https://jira.coreos.com/browse/ODC-2190

@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. component/dev-console Related to dev-console component/knative Related to knative-plugin labels Nov 5, 2019
andrewballantyne
andrewballantyne suggested changes Nov 5, 2019
View reviewed changes
Comment thread frontend/packages/knative-plugin/src/utils/get-knative-resources.ts Outdated

@andrewballantyne andrewballantyne Nov 5, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't be easier to just not do this if-statement?

@andrewballantyne andrewballantyne Nov 5, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thats... not what I meant. I meant just not do the logic in the if-statement when you didn't have the data for it.

You were only doing a filter.

@invincibleJai invincibleJai Nov 5, 2019

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you mean not to do filter if data is not there, default value id [] so shall I have a check ?

@invincibleJai

invincibleJai commented Nov 5, 2019

Copy link
Copy Markdown
Member Author

/kind bug

@openshift-ci-robot openshift-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Nov 5, 2019
@invincibleJai

invincibleJai commented Nov 5, 2019

Copy link
Copy Markdown
Member Author

/cc @joshuawilson

@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 6, 2019
@invincibleJai

invincibleJai commented Nov 6, 2019

Copy link
Copy Markdown
Member Author

/test frontend

@invincibleJai

invincibleJai commented Nov 6, 2019

Copy link
Copy Markdown
Member Author

/retest

rohitkrai03
rohitkrai03 approved these changes Nov 6, 2019
View reviewed changes

@rohitkrai03 rohitkrai03 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 6, 2019
@invincibleJai

invincibleJai commented Nov 6, 2019

Copy link
Copy Markdown
Member Author

/test e2e-gcp-console

@gijohn

gijohn commented Nov 7, 2019

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 7, 2019
@openshift-ci-robot

openshift-ci-robot commented Nov 7, 2019

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gijohn, invincibleJai, rohitkrai03

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@invincibleJai

invincibleJai commented Nov 7, 2019

Copy link
Copy Markdown
Member Author

/test e2e-gcp-console

1 similar comment
@invincibleJai

invincibleJai commented Nov 7, 2019

Copy link
Copy Markdown
Member Author

/test e2e-gcp-console

@spadgett spadgett added this to the v4.3 milestone Nov 7, 2019
@christianvogt

christianvogt commented Nov 7, 2019

Copy link
Copy Markdown
Contributor

/retest

1 similar comment
@andrewballantyne

andrewballantyne commented Nov 7, 2019

Copy link
Copy Markdown
Contributor

/retest

@andrewballantyne

andrewballantyne commented Nov 7, 2019

Copy link
Copy Markdown
Contributor

/retest

1 similar comment
@andrewballantyne

andrewballantyne commented Nov 8, 2019

Copy link
Copy Markdown
Contributor

/retest

@openshift-merge-robot
openshift-merge-robot merged commit 7ab3f51 into openshift:master Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sahil143 sahil143 Awaiting requested review from sahil143
@joshuawilson joshuawilson Awaiting requested review from joshuawilson
2 more reviewers
@andrewballantyne andrewballantyne andrewballantyne requested changes
@rohitkrai03 rohitkrai03 rohitkrai03 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@gijohn gijohn

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. component/dev-console Related to dev-console component/knative Related to knative-plugin kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

v4.3

Development

Successfully merging this pull request may close these issues.

8 participants

@invincibleJai @gijohn @openshift-ci-robot @christianvogt @andrewballantyne @rohitkrai03 @spadgett @openshift-merge-robot