Alertmanager: Add missing <title> to Overview and YAML pages - #3271
Merged
openshift-merge-robot merged 1 commit intoNov 12, 2019
Merged
Conversation
openshift-ci-robot
added
component/core
spadgett
requested changes
Nov 6, 2019
Member
There was a problem hiding this comment.
We should match the page heading.
Suggested change
| <title>Alertmanager Overview</title> | |
| <title>Alerting</title> |
Member
There was a problem hiding this comment.
Suggested change
| <title>Alertmanager YAML</title> | |
| <title>Alerting</title> |
Member
There was a problem hiding this comment.
Thanks @spadgett, @dtaylor113. I think #3255 should also use the static Alerting to match the page heading, so I've updated that PR.
Contributor
Author
Member
|
/kind bug |
openshift-ci-robot
added
the
kind/bug
dtaylor113
force-pushed
the
alertmanager-config-title
branch
from
November 7, 2019 13:57
29a581b to
dd15747
Compare
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dtaylor113, spadgett The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added 'Alerting'
<Title />element.