Skip to content

Add a null check for params in pipeline template - #3306

Merged
openshift-merge-robot merged 1 commit into
openshift:masterfrom
rohitkrai03:bug-odc-2202
Nov 11, 2019
Merged

Add a null check for params in pipeline template#3306
openshift-merge-robot merged 1 commit into
openshift:masterfrom
rohitkrai03:bug-odc-2202

Conversation

@rohitkrai03

Copy link
Copy Markdown
Contributor

Related Bug - https://jira.coreos.com/browse/ODC-2202

This PR

  • Fixes the issue of pipeline resource creating failing if no params in pipeline template.

@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 8, 2019
@divyanshiGupta

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 8, 2019
@gijohn

gijohn commented Nov 8, 2019

Copy link
Copy Markdown
Contributor

/lgtm
/test e2e-gcp-console

@openshift-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: divyanshiGupta, gijohn, rohitkrai03

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spadgett

spadgett commented Nov 9, 2019

Copy link
Copy Markdown
Member

/retest

@spadgett spadgett added this to the v4.3 milestone Nov 9, 2019
@rohitkrai03

Copy link
Copy Markdown
Contributor Author

/test e2e-gcp-console

@rohitkrai03

Copy link
Copy Markdown
Contributor Author

/retest

@openshift-merge-robot
openshift-merge-robot merged commit 3ff9a57 into openshift:master Nov 11, 2019
@rohitkrai03
rohitkrai03 deleted the bug-odc-2202 branch March 30, 2020 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. component/dev-console Related to dev-console lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants