Skip to content

Bug 1767072: Fix catalog source links in install plan details - #3316

Merged
openshift-merge-robot merged 1 commit into
openshift:masterfrom
TheRealJon:1767072-bz
Nov 18, 2019
Merged

Bug 1767072: Fix catalog source links in install plan details#3316
openshift-merge-robot merged 1 commit into
openshift:masterfrom
TheRealJon:1767072-bz

Conversation

@TheRealJon

@TheRealJon TheRealJon commented Nov 8, 2019

Copy link
Copy Markdown
Member

https://bugzilla.redhat.com/show_bug.cgi?id=1767072

Change default namespace for catalog sources to 'openshift-marketplace'.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Nov 8, 2019
@openshift-ci-robot

openshift-ci-robot commented Nov 8, 2019

Copy link
Copy Markdown
Contributor

@TheRealJon: This pull request references Bugzilla bug 1767072, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Bug 1767072: Fix catalog source links in install plan details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. component/olm Related to OLM labels Nov 8, 2019
spadgett
spadgett reviewed Nov 8, 2019
View reviewed changes
Comment thread frontend/packages/operator-lifecycle-manager/src/components/install-plan.tsx Outdated
Comment thread frontend/packages/operator-lifecycle-manager/src/plugin.tsx Outdated
spadgett
spadgett reviewed Nov 8, 2019
View reviewed changes
Comment thread frontend/packages/operator-lifecycle-manager/src/components/install-plan.tsx Outdated
@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 14, 2019
@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 14, 2019
spadgett
spadgett reviewed Nov 14, 2019
View reviewed changes
Comment thread frontend/packages/operator-lifecycle-manager/src/components/catalog-source.tsx Outdated
@TheRealJon

TheRealJon commented Nov 18, 2019

Copy link
Copy Markdown
Member Author

/restest

spadgett
spadgett reviewed Nov 18, 2019
View reviewed changes
Comment thread frontend/packages/operator-lifecycle-manager/src/components/install-plan.tsx Outdated
spadgett
spadgett approved these changes Nov 18, 2019
View reviewed changes

@spadgett spadgett left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 18, 2019
@openshift-ci-robot

openshift-ci-robot commented Nov 18, 2019

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: spadgett, TheRealJon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 18, 2019
@openshift-merge-robot
openshift-merge-robot merged commit 2207685 into openshift:master Nov 18, 2019
@openshift-ci-robot

openshift-ci-robot commented Nov 18, 2019

Copy link
Copy Markdown
Contributor

@TheRealJon: All pull requests linked via external trackers have merged. Bugzilla bug 1767072 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1767072: Fix catalog source links in install plan details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@TheRealJon
TheRealJon deleted the 1767072-bz branch November 18, 2019 18:30
@spadgett spadgett mentioned this pull request Nov 18, 2019
Merged
@spadgett spadgett added this to the v4.3 milestone Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@spadgett spadgett spadgett approved these changes
@jeff-phillips-18 jeff-phillips-18 Awaiting requested review from jeff-phillips-18

Assignees

@spadgett spadgett

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/olm Related to OLM lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

v4.3

Development

Successfully merging this pull request may close these issues.

4 participants

@TheRealJon @openshift-ci-robot @spadgett @openshift-merge-robot