Skip to content

Bug 1770808: Link to dev perspective metrics if admin monitoring is not available - #3333

Merged
openshift-merge-robot merged 1 commit into
openshift:masterfrom
rawagner:fix_view_more_link
Nov 11, 2019
Merged

Bug 1770808: Link to dev perspective metrics if admin monitoring is not available#3333
openshift-merge-robot merged 1 commit into
openshift:masterfrom
rawagner:fix_view_more_link

Conversation

@rawagner

Copy link
Copy Markdown
Contributor

No description provided.

@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@rawagner: This pull request references Bugzilla bug 1770808, which is invalid:

  • expected the bug to target the "4.3.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1770808: Link to dev perspective metrics if admin monitoring is not available

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. component/dashboard Related to dashboard component/shared Related to console-shared size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 11, 2019
@rawagner

Copy link
Copy Markdown
Contributor Author

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Nov 11, 2019
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@rawagner: This pull request references Bugzilla bug 1770808, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 11, 2019
@spadgett spadgett added this to the v4.3 milestone Nov 11, 2019
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rawagner, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot
openshift-merge-robot merged commit becfed5 into openshift:master Nov 11, 2019
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@rawagner: All pull requests linked via external trackers have merged. Bugzilla bug 1770808 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1770808: Link to dev perspective metrics if admin monitoring is not available

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lizsurette

Copy link
Copy Markdown

@rawagner - Does this mean we will show the Dashboards page to a dev user after all? Today, we hide this tab for certain roles.

@rawagner

Copy link
Copy Markdown
Contributor Author

@lizsurette it's for other dashboards we show to user such as Project and VM. Dashboards page can still be seen only by admins and they can also see monitoring section so there wont be any difference

@lizsurette

Copy link
Copy Markdown

@lizsurette it's for other dashboards we show to user such as Project and VM. Dashboards page can still be seen only by admins and they can also see monitoring section so there wont be any difference

@rawagner - Makes sense. Thanks for clarifying!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/dashboard Related to dashboard component/shared Related to console-shared lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants