Skip to content

Add standard icon for Camel - #3368

Merged
openshift-merge-robot merged 1 commit into
openshift:masterfrom
nicolaferraro:camel-icon
Nov 14, 2019
Merged

Add standard icon for Camel#3368
openshift-merge-robot merged 1 commit into
openshift:masterfrom
nicolaferraro:camel-icon

Conversation

@nicolaferraro

@nicolaferraro nicolaferraro commented Nov 12, 2019

Copy link
Copy Markdown
Contributor

No description provided.

@openshift-ci-robot

openshift-ci-robot commented Nov 12, 2019

Copy link
Copy Markdown
Contributor

Hi @nicolaferraro. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. component/core Related to console core functionality labels Nov 12, 2019
@spadgett

spadgett commented Nov 13, 2019

Copy link
Copy Markdown
Member

/assign @rhamilto

@spadgett

spadgett commented Nov 13, 2019

Copy link
Copy Markdown
Member

/ok-to-test

@openshift-ci-robot openshift-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 13, 2019
@nicolaferraro

nicolaferraro commented Nov 13, 2019

Copy link
Copy Markdown
Contributor Author

/test e2e-gcp-console

rhamilto
rhamilto approved these changes Nov 13, 2019
View reviewed changes

@rhamilto rhamilto left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 13, 2019
@openshift-ci-robot

openshift-ci-robot commented Nov 13, 2019

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nicolaferraro, rhamilto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 13, 2019
@openshift-bot

openshift-bot commented Nov 14, 2019

Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot

openshift-bot commented Nov 14, 2019

Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

openshift-bot commented Nov 14, 2019

Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot
openshift-merge-robot merged commit a49e048 into openshift:master Nov 14, 2019
@spadgett spadgett added this to the v4.3 milestone Nov 18, 2019
@rhamilto rhamilto mentioned this pull request Dec 4, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rhamilto rhamilto rhamilto approved these changes
@jeff-phillips-18 jeff-phillips-18 Awaiting requested review from jeff-phillips-18
@spadgett spadgett Awaiting requested review from spadgett

Assignees

@rhamilto rhamilto

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

v4.3

Development

Successfully merging this pull request may close these issues.

6 participants

@nicolaferraro @openshift-ci-robot @spadgett @openshift-bot @rhamilto @openshift-merge-robot