Skip to content

Fix bug where "Installed Operators" nav item isn't correctly activated - #3386

Merged
openshift-merge-robot merged 1 commit into
openshift:masterfrom
rhamilto:operators-nav-fix
Nov 14, 2019
Merged

Fix bug where "Installed Operators" nav item isn't correctly activated#3386
openshift-merge-robot merged 1 commit into
openshift:masterfrom
rhamilto:operators-nav-fix

Conversation

@rhamilto

@rhamilto rhamilto commented Nov 13, 2019 •
edited
Loading

Copy link
Copy Markdown
Member

@openshift-ci-robot openshift-ci-robot added component/olm Related to OLM size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 13, 2019
@spadgett spadgett added this to the v4.3 milestone Nov 13, 2019
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 13, 2019
@rhamilto

rhamilto commented Nov 13, 2019

Copy link
Copy Markdown
Member Author

/retest

1 similar comment
@rhamilto

rhamilto commented Nov 13, 2019

Copy link
Copy Markdown
Member Author

/retest

@rhamilto

rhamilto commented Nov 13, 2019

Copy link
Copy Markdown
Member Author

/hold

this is bug

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 13, 2019
@spadgett

spadgett commented Nov 13, 2019

Copy link
Copy Markdown
Member

Hm, I think we might have broken existing links with the 4.3 changes.

https://github.com/openshift/console/blob/release-4.2/frontend/public/components/nav/admin-nav.tsx#L84-L88

@spadgett

spadgett commented Nov 13, 2019

Copy link
Copy Markdown
Member

The link here uses the resource plural instead of the full reference:

https://github.com/spadgett/console/blob/734c751b82d3a2f5142a57b7845bf83eb5a9b5db/frontend/packages/operator-lifecycle-manager/src/components/index.tsx#L120-L126

@spadgett

spadgett commented Nov 13, 2019

Copy link
Copy Markdown
Member

OK, I see that we support either the plural or full reference

https://github.com/openshift/console/blob/master/frontend/packages/operator-lifecycle-manager/src/plugin.tsx#L108-L125

spadgett
spadgett reviewed Nov 13, 2019
View reviewed changes
Comment thread frontend/packages/operator-lifecycle-manager/src/plugin.tsx Outdated
spadgett
spadgett approved these changes Nov 13, 2019
View reviewed changes

@spadgett spadgett left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 13, 2019
@spadgett

spadgett commented Nov 13, 2019

Copy link
Copy Markdown
Member

/kind bug

Feel free to cancel the hold if ready

@openshift-ci-robot openshift-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Nov 13, 2019
@openshift-ci-robot

openshift-ci-robot commented Nov 13, 2019

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhamilto, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rhamilto

rhamilto commented Nov 13, 2019

Copy link
Copy Markdown
Member Author

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 13, 2019
@rhamilto

rhamilto commented Nov 13, 2019

Copy link
Copy Markdown
Member Author

/retest

@openshift-bot

openshift-bot commented Nov 14, 2019

Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot

openshift-bot commented Nov 14, 2019

Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot
openshift-merge-robot merged commit 6a270aa into openshift:master Nov 14, 2019
@rhamilto
rhamilto deleted the operators-nav-fix branch November 14, 2019 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@spadgett spadgett spadgett approved these changes
@jeff-phillips-18 jeff-phillips-18 Awaiting requested review from jeff-phillips-18

Assignees

@spadgett spadgett

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. component/olm Related to OLM kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

v4.3

Development

Successfully merging this pull request may close these issues.

5 participants

@rhamilto @spadgett @openshift-ci-robot @openshift-bot @openshift-merge-robot