Skip to content

Bug 1771744: fix NAD loading in NIC dialog - #3395

Merged
openshift-merge-robot merged 1 commit into
openshift:masterfrom
atiratree:kubevirt.fixNICLoading
Nov 14, 2019
Merged

Bug 1771744: fix NAD loading in NIC dialog#3395
openshift-merge-robot merged 1 commit into
openshift:masterfrom
atiratree:kubevirt.fixNICLoading

Conversation

@atiratree

@atiratree atiratree commented Nov 14, 2019

Copy link
Copy Markdown
Member

No description provided.

@openshift-ci-robot

openshift-ci-robot commented Nov 14, 2019

Copy link
Copy Markdown
Contributor

@suomiy: This pull request references Bugzilla bug 1771744, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Bug 1771744: fix NAD loading in NIC dialog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. component/kubevirt Related to kubevirt-plugin labels Nov 14, 2019
@mareklibra

mareklibra commented Nov 14, 2019

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 14, 2019
@openshift-ci-robot

openshift-ci-robot commented Nov 14, 2019

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mareklibra, suomiy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot
openshift-merge-robot merged commit 4e2b789 into openshift:master Nov 14, 2019
@openshift-ci-robot

openshift-ci-robot commented Nov 14, 2019

Copy link
Copy Markdown
Contributor

@suomiy: All pull requests linked via external trackers have merged. Bugzilla bug 1771744 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1771744: fix NAD loading in NIC dialog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.3 milestone Nov 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mareklibra mareklibra Awaiting requested review from mareklibra
@vojtechszocs vojtechszocs Awaiting requested review from vojtechszocs

Assignees

@mareklibra mareklibra

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/kubevirt Related to kubevirt-plugin lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

v4.3

Development

Successfully merging this pull request may close these issues.

6 participants

@atiratree @openshift-ci-robot @mareklibra @spadgett @openshift-merge-robot @suomiy