Skip to content

Bug: fix network/storage row kebab focus in createVMWizard - #3412

Closed
atiratree wants to merge 2 commits into
openshift:masterfrom
atiratree:kubevirt.fixCreateVMWizardKebab
Closed

Bug: fix network/storage row kebab focus in createVMWizard#3412
atiratree wants to merge 2 commits into
openshift:masterfrom
atiratree:kubevirt.fixCreateVMWizardKebab

Conversation

@atiratree

Copy link
Copy Markdown
Member

@openshift-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: suomiy
To complete the pull request process, please assign jhadvig
You can assign the PR to them by writing /assign @jhadvig in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 15, 2019
@openshift-ci-robot openshift-ci-robot added component/core Related to console core functionality component/kubevirt Related to kubevirt-plugin labels Nov 15, 2019
@christianvogt

Copy link
Copy Markdown
Contributor

@suomiy could you share some screenshots and describe the problem. Was this a result of the recent kebab changes?

@atiratree

Copy link
Copy Markdown
Member Author

@suomiy could you share some screenshots and describe the problem.

it is not possible to focus or select kebab options. This has to do with the wizard z-indexes

Was this a result of the recent kebab changes?

yes

aa

@christianvogt

Copy link
Copy Markdown
Contributor

@suomiy We're better to apply a default z-index value to the Popper itself.
I created a PR: #3431
Let me know if this solves your issue.

@christianvogt

Copy link
Copy Markdown
Contributor

A default z index is now applied to the kebab which should solve your problem.

@atiratree

Copy link
Copy Markdown
Member Author

@christianvogt works great, thanks!

@atiratree atiratree closed this Nov 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component/core Related to console core functionality component/kubevirt Related to kubevirt-plugin size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants