Skip to content

Changed from consensus to maximal for unit selection - #3418

Merged
openshift-merge-robot merged 1 commit into
openshift:masterfrom
bipuladh:y-tick-fix
Nov 18, 2019
Merged

Changed from consensus to maximal for unit selection#3418
openshift-merge-robot merged 1 commit into
openshift:masterfrom
bipuladh:y-tick-fix

Conversation

@bipuladh

Copy link
Copy Markdown
Contributor
  • Changed data frame normalization function to accomodate edge cases.
    Before:
    error_img_y_ticks
    After:
    Screenshot from 2019-11-15 20-01-10

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 15, 2019
@openshift-ci-robot openshift-ci-robot added the component/shared Related to console-shared label Nov 15, 2019
@bipuladh

Copy link
Copy Markdown
Contributor Author

/assign @TheRealJon

@TheRealJon

Copy link
Copy Markdown
Member

/retest

@TheRealJon TheRealJon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 15, 2019
@bipuladh

Copy link
Copy Markdown
Contributor Author

/assign @spadgett

@TheRealJon

Copy link
Copy Markdown
Member

/approve

1 similar comment
@spadgett

Copy link
Copy Markdown
Member

/approve

@openshift-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bipuladh, spadgett, TheRealJon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 18, 2019
@openshift-bot

Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot

Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot
openshift-merge-robot merged commit cb65e3d into openshift:master Nov 18, 2019
@spadgett spadgett added this to the v4.3 milestone Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. component/shared Related to console-shared lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants