tests: improve coverage of other routes in crud scenario - #3432
Merged
Conversation
spadgett
commented
Nov 16, 2019
spadgett
commented
Member
- Add LimitRange to standard CRUD tests
- Add OpenShift routes and remove out-of-date paths
- Detect error pages, not just runtime errors, for other routes
openshift-ci-robot
added
component/core
openshift-ci-robot
added
the
approved
* Add LimitRange to standard CRUD tests * Add OpenShift routes and remove out-of-date paths * Detect error pages, not just runtime errors, for other routes
spadgett
force-pushed
the
special-routes
branch
from
November 16, 2019 13:33
1cbea2c to
b47a498
Compare
Member
Author
|
/retest |
1 similar comment
Member
Author
|
/retest |
Member
Author
|
/assign @rhamilto |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhamilto, spadgett The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
|
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
Contributor
|
/retest Please review the full test history for this PR and help us cut down flakes. |
Contributor
|
/retest Please review the full test history for this PR and help us cut down flakes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.