Skip to content

Address the optional nature of knative on the Add Page - #3501

Merged
openshift-merge-robot merged 1 commit into
openshift:masterfrom
andrewballantyne:fix-add-page
Nov 21, 2019
Merged

Address the optional nature of knative on the Add Page#3501
openshift-merge-robot merged 1 commit into
openshift:masterfrom
andrewballantyne:fix-add-page

Conversation

@andrewballantyne

@andrewballantyne andrewballantyne commented Nov 20, 2019

Copy link
Copy Markdown
Contributor

Got a NPE on the Add Page when Knative isn't installed.

https://jira.coreos.com/browse/ODC-2340

It's an optional resource, so it shouldn't be expected to be part of the resources array.

    {
      isList: true,
      kind: referenceForModel(ServiceModel),
      namespace,
      prop: 'knativeService',
      optional: true,
      limit: 1,
    },

/cc @debsmita1

@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. component/dev-console Related to dev-console labels Nov 20, 2019
@andrewballantyne

Copy link
Copy Markdown
Contributor Author

/retest

@christianvogt

Copy link
Copy Markdown
Contributor

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 21, 2019
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewballantyne, christianvogt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 21, 2019
@openshift-merge-robot
openshift-merge-robot merged commit c89478f into openshift:master Nov 21, 2019
@spadgett spadgett added this to the v4.3 milestone Nov 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. component/dev-console Related to dev-console lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants