Skip to content

Add icons to replication controller status - #3530

Merged
openshift-merge-robot merged 1 commit into
openshift:masterfrom
spadgett:rc-status-icon
Nov 21, 2019
Merged

Add icons to replication controller status#3530
openshift-merge-robot merged 1 commit into
openshift:masterfrom
spadgett:rc-status-icon

Conversation

@spadgett

Copy link
Copy Markdown
Member

Replication controllers weren't using the standard Status component, so were missing icons.

/kind bug
/assign @rhamilto

example · Details · OKD 2019-11-21 14-03-48

@openshift-ci-robot openshift-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Nov 21, 2019
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 21, 2019
@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality labels Nov 21, 2019
@spadgett

Copy link
Copy Markdown
Member Author

example-1 · Details · OKD 2019-11-21 14-06-34

@rhamilto rhamilto left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 21, 2019
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhamilto, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spadgett spadgett added this to the v4.3 milestone Nov 21, 2019
@openshift-merge-robot
openshift-merge-robot merged commit 4b34876 into openshift:master Nov 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants