Skip to content

Bug 1775379: Don't show Prometheus UI link when not discovered - #3533

Merged
openshift-merge-robot merged 1 commit into
openshift:masterfrom
spadgett:prometheus-link
Nov 22, 2019
Merged

Bug 1775379: Don't show Prometheus UI link when not discovered#3533
openshift-merge-robot merged 1 commit into
openshift:masterfrom
spadgett:prometheus-link

Conversation

@spadgett

Copy link
Copy Markdown
Member

/assign @kyoto

@spadgett spadgett added this to the v4.3 milestone Nov 21, 2019
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@spadgett: This pull request references Bugzilla bug 1775379, which is invalid:

  • expected the bug to target the "4.3.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1775379: Don't show Prometheus UI link when not discovered

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. component/core Related to console core functionality component/monitoring Related to monitoring labels Nov 21, 2019
@spadgett

Copy link
Copy Markdown
Member Author

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Nov 21, 2019
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@spadgett: This pull request references Bugzilla bug 1775379, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kyoto

kyoto commented Nov 22, 2019

Copy link
Copy Markdown
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 22, 2019
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kyoto, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot
openshift-merge-robot merged commit d79b867 into openshift:master Nov 22, 2019
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@spadgett: All pull requests linked via external trackers have merged. Bugzilla bug 1775379 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1775379: Don't show Prometheus UI link when not discovered

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/core Related to console core functionality component/monitoring Related to monitoring lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants