Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,7 @@ export const sampleKnativeConfigurations: FirehoseResult = {
},
ownerReferences: [
{
apiVersion: `${ServiceModel.apiGroup}/${ServiceModel.apiVersion}`,
apiVersion: `${RouteModel.apiGroup}/${RouteModel.apiVersion}`,
kind: RouteModel.kind,
name: 'overlayimage',
uid: 'cea9496b-8ce0-11e9-bb7b-0ebb55b110b8',
Expand Down Expand Up @@ -452,8 +452,8 @@ export const sampleEventSourceCamel: FirehoseResult = {
},
spec: {
sink: {
apiVersion: 'serving.knative.dev/v1beta1',
kind: 'Service',
apiVersion: `${ServiceModel.apiGroup}/${ServiceModel.apiVersion}`,
kind: ServiceModel.kind,
name: 'overlayimage',
},
},
Expand All @@ -476,8 +476,8 @@ export const sampleEventSourceKafka: FirehoseResult = {
},
spec: {
sink: {
apiVersion: 'serving.knative.dev/v1beta1',
kind: 'Service',
apiVersion: `${ServiceModel.apiGroup}/${ServiceModel.apiVersion}`,
kind: ServiceModel.kind,
name: 'overlayimage',
},
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ const EventSinkServicesOverviewList: React.FC<EventSinkServicesOverviewListProps
/>
{sinkUri && (
<>
<span className="text-muted">Sink uri: </span>
<span className="text-muted">Sink URI: </span>
<ExternalLink
href={sinkUri}
additionalClassName="co-external-link--block"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ describe('RevisionRow', () => {
expect(wrapper.find(TableData)).toHaveLength(8);
expect(serviceDataTable.find(ResourceLink)).toHaveLength(1);
expect(serviceDataTable.find(ResourceLink).props().kind).toEqual(
'serving.knative.dev~v1beta1~Service',
'serving.knative.dev~v1~Service',
);
});

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ describe('RouteRow', () => {
const trafficColData = wrapper.find(TableData).at(5);
expect(trafficColData.find(ResourceLink)).toHaveLength(1);
expect(trafficColData.find(ResourceLink).props().kind).toEqual(
'serving.knative.dev~v1beta1~Revision',
'serving.knative.dev~v1~Revision',
);
});

Expand Down
2 changes: 1 addition & 1 deletion frontend/packages/knative-plugin/src/models.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import {
import { K8sKind } from '@console/internal/module/k8s';
import { BadgeType } from '@console/shared/src/components/badges/badge-factory';

const apiVersion = `v1beta1`;
const apiVersion = 'v1';

export const ConfigurationModel: K8sKind = {
apiGroup: 'serving.knative.dev',
Expand Down
6 changes: 4 additions & 2 deletions frontend/packages/knative-plugin/src/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@ import { K8sResourceKind, K8sResourceCondition } from '@console/internal/module/
export type ConfigurationKind = K8sResourceKind;

export type RevisionKind = {
status: {
conditions: K8sResourceCondition<ConditionTypes>[];
status?: {
conditions?: K8sResourceCondition<ConditionTypes>[];
};
} & K8sResourceKind;

Expand All @@ -14,6 +14,7 @@ export type ServiceKind = K8sResourceKind & {
};
status?: {
url?: string;
traffic?: Traffic[];
};
};

Expand All @@ -35,4 +36,5 @@ export type Traffic = {
revisionName: string;
percent: number;
latestRevision?: boolean;
tag?: string;
};
Original file line number Diff line number Diff line change
@@ -1,10 +1,13 @@
import { RevisionModel, ServiceModel } from '../../models';
import { RevisionKind, ServiceKind as knativeServiceKind } from '../../types';

export const mockTrafficData = [
{ percent: 50, tag: 'tag-1', revisionName: 'rev-1' },
{ percent: 50, tag: 'tag-2', revisionName: 'rev-2' },
];
export const mockServiceData = {
apiVersion: 'serving.knative.dev/v1beta1',
kind: 'Service',
export const mockServiceData: knativeServiceKind = {
apiVersion: `${ServiceModel.apiGroup}/${ServiceModel.apiVersion}`,
kind: ServiceModel.kind,
spec: {
traffic: [
{
Expand All @@ -31,9 +34,9 @@ export const mockServiceData = {
},
};

export const mockUpdateRequestObj = {
apiVersion: 'serving.knative.dev/v1beta1',
kind: 'Service',
export const mockUpdateRequestObj: knativeServiceKind = {
apiVersion: `${ServiceModel.apiGroup}/${ServiceModel.apiVersion}`,
kind: ServiceModel.kind,
spec: {
traffic: [
{
Expand All @@ -50,26 +53,26 @@ export const mockUpdateRequestObj = {
},
};

export const mockRevisions = [
export const mockRevisions: RevisionKind[] = [
{
apiVersion: 'serving.knative.dev/v1beta1',
kind: 'Revision',
apiVersion: `${RevisionModel.apiGroup}/${RevisionModel.apiVersion} `,
kind: RevisionModel.kind,
metadata: {
name: 'rev-1',
namespace: 'namespace',
},
},
{
apiVersion: 'serving.knative.dev/v1beta1',
kind: 'Revision',
apiVersion: `${RevisionModel.apiGroup}/${RevisionModel.apiVersion}`,
kind: RevisionModel.kind,
metadata: {
name: 'rev-2',
namespace: 'namespace',
},
},
{
apiVersion: 'serving.knative.dev/v1beta1',
kind: 'Revision',
apiVersion: `${RevisionModel.apiGroup}/${RevisionModel.apiVersion}`,
kind: RevisionModel.kind,
metadata: {
name: 'rev-3',
namespace: 'namespace',
Expand Down