Skip to content

Bug 1835636: Add limit for PVC for BS creation#5508

Closed
a2batic wants to merge 1 commit into
openshift:masterfrom
a2batic:bug-1835636
Closed

Bug 1835636: Add limit for PVC for BS creation#5508
a2batic wants to merge 1 commit into
openshift:masterfrom
a2batic:bug-1835636

Conversation

@a2batic

@a2batic a2batic commented May 20, 2020

Copy link
Copy Markdown
Contributor

Before:
Screenshot from 2020-05-21 13-33-11

After:
Screenshot from 2020-05-21 13-29-27

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels May 20, 2020
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@a2batic: This pull request references Bugzilla bug 1835636, which is invalid:

  • expected the bug to target the "4.5.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1835636: Add limit for PVC for BS creation

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the component/noobaa Related to noobaa-storage-plugin label May 20, 2020
@a2batic

a2batic commented May 20, 2020

Copy link
Copy Markdown
Contributor Author

/assign @afreen23 @gnehapk

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<PlusIcon onClick={add} />{' '}
<PlusIcon onClick={add} />

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same for the MinusIcon as well

@a2batic

a2batic commented May 21, 2020

Copy link
Copy Markdown
Contributor Author

/bugzilla refresh

@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@a2batic: This pull request references Bugzilla bug 1835636, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels May 21, 2020
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@a2batic: This pull request references Bugzilla bug 1835636, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
Details

In response to this:

Bug 1835636: Add limit for PVC for BS creation

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 21, 2020
@a2batic
a2batic requested a review from gnehapk May 21, 2020 08:30
@gnehapk

gnehapk commented May 21, 2020

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 21, 2020
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a2batic, afreen23, bipuladh, gnehapk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cloudbehl

Copy link
Copy Markdown
Contributor

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 21, 2020
@gnehapk

gnehapk commented May 21, 2020

Copy link
Copy Markdown
Contributor

Pushing this validation on backend so that it can be handled for both UI and CLI.

@bipuladh

Copy link
Copy Markdown
Contributor

/close
as BE will be implementing this validaiton

@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@bipuladh: Closed this PR.

Details

In response to this:

/close
as BE will be implementing this validaiton

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/noobaa Related to noobaa-storage-plugin do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants