OCPBUGS-99200: Add networking.k8s.io group policy

[mpatlasov]

https://redhat.atlassian.net/browse/OCPBUGS-99200

Add networking.k8s.io/networkpolicies RBAC to the SMB CSI driver operator CSV to pass the olm.required_network_policy_rbac_for_operands Conforma check, which becomes a release blocker on August 8th.

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[openshift-ci-robot]

@mpatlasov: This pull request references Jira Issue OCPBUGS-99200, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (5.0.0) matches configured target version for branch (5.0.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

https://redhat.atlassian.net/browse/OCPBUGS-99200

Add networking.k8s.io/networkpolicies RBAC to the SMB CSI driver operator CSV to pass the olm.required_network_policy_rbac_for_operands Conforma check, which becomes a release blocker on August 8th.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mpatlasov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [mpatlasov]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 5ef9d258-523a-4154-900a-20991d3f57e7

📥 Commits

Reviewing files that changed from the base of the PR and between 1f64834 and 6d06ba8.

📒 Files selected for processing (1)

• config/samba/manifests/stable/smb-csi-driver-operator.clusterserviceversion.yaml

---

📝 Walkthrough

Walkthrough

The Samba CSI driver operator ClusterServiceVersion adds a cluster-scoped RBAC rule for networkpolicies in the networking.k8s.io API group, granting create, delete, and update permissions.

Suggested reviewers: dobsonj

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title matches the change to add networking.k8s.io RBAC for the operator.
Description check	✅ Passed	The description clearly describes the networkpolicies RBAC change and its purpose.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	Only a CSV manifest changed; no Ginkgo tests or titles were added or modified.
Test Structure And Quality	✅ Passed	PR only changes a CSV RBAC manifest; no Ginkgo tests were added or modified, so this test-quality check is not applicable.
Microshift Test Compatibility	✅ Passed	Only a CSV RBAC manifest changed; no Ginkgo/e2e test files or test constructs were added.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	Only a CSV manifest changed; no new or modified Ginkgo/e2e tests were added, so the SNO compatibility check is not applicable.
Topology-Aware Scheduling Compatibility	✅ Passed	Only a networkpolicies RBAC rule was added; the Deployment’s affinity/tolerations and replica count were unchanged.
Ote Binary Stdout Contract	✅ Passed	PR only edits a CSV manifest; no process-level Go code or stdout/logging changes are present, so the OTE stdout contract is unaffected.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	No new Ginkgo/e2e tests were added; the PR only updates a CSV RBAC manifest, so there are no IPv4 or external-connectivity assumptions to flag.
No-Weak-Crypto	✅ Passed	The PR only adds RBAC for networking.k8s.io/networkpolicies in a CSV; no MD5/SHA1/DES/RC4/3DES/Blowfish/ECB or crypto code appears.
Container-Privileges	✅ Passed	Change only adds networkpolicy RBAC; the CSV still uses restrictive securityContext (allowPrivilegeEscalation: false, runAsNonRoot: true) and no privileged flags.
No-Sensitive-Data-In-Logs	✅ Passed	The patch only adds RBAC for networkpolicies in a CSV manifest; no logging or sensitive-data output was introduced.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[dfajmon]

/lgtm
/verified by dfajmon

[openshift-ci-robot]

@dfajmon: This PR has been marked as verified by dfajmon.

Details

In response to this:

/lgtm
/verified by dfajmon

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-merge-bot]

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-upgrade
/test e2e-azure
/test e2e-azure-csi
/test e2e-azure-file-csi
/test e2e-azure-file-nfs-csi
/test e2e-azure-ovn-upgrade
/test e2e-gcp
/test e2e-gcp-csi
/test e2e-gcp-ovn-upgrade

[openshift-merge-bot]

/retest-required

Remaining retests: 0 against base HEAD 1da4798 and 2 for PR HEAD 6d06ba8 in total

[dfajmon]

/retest-required

[mpatlasov]

/retest-required

[dfajmon]

/retest-required

[dfajmon]

/retest-required

[dfajmon]

/retest-required

[mpatlasov]

/retest-required

[openshift-ci]

@mpatlasov: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/hypershift-e2e-aks	6d06ba8	link	false	/test hypershift-e2e-aks
ci/prow/e2e-gcp	6d06ba8	link	true	/test e2e-gcp

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.