[release-4.16] OCPBUGS-102919: CVE-2026-33814: replace golang.org/x/net with openshift-sustaining fork - #608
Conversation
…ft-sustaining fork golang.org/x/net's real fix (v0.53.0) requires go>=1.25, but this branch's builder is pinned to Go 1.21 (registry.ci.openshift.org/ocp/builder:rhel-9-golang-1.21-openshift-4.16), so a direct module bump is not buildable here. Uses `replace golang.org/x/net => github.com/openshift-sustaining/net v0.35.0-sec.3` (sustaining team's own downstream fork, go 1.18+ compatible) which backports only the CVE-2026-33814 fix (SETTINGS_MAX_FRAME_SIZE=0 validation in processSettingsNoWrite) without requiring the toolchain bump. Verified: - go build ./... and go vet ./... clean with the branch's real Go 1.21 toolchain. - govulncheck -mode=source on ./cmd/azure-disk-csi-driver-operator/...: GO-2026-4918 no longer reported (neither Symbol nor Package results; golang.org/x/net does not appear at all in the report since the module resolves to the fork). - Vendored fix confirmed identical to upstream golang/go@e3a10fe3749e (CL 761581). Co-authored-by: Cursor <cursoragent@cursor.com>
|
Pipeline controller notification For optional jobs, comment This repository is configured in: LGTM mode |
|
@mariocr73: This pull request references Jira Issue OCPBUGS-102919, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
|
/lgtm |
|
Scheduling required tests: |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dobsonj, mariocr73 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@mariocr73: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
golang.org/x/net's real fix (v0.53.0) requires go>=1.25, but this branch's builder is pinned to Go 1.21 (rhel-9-golang-1.21-openshift-4.16), so a direct module bump is not buildable here.
Uses
replace golang.org/x/net => github.com/openshift-sustaining/net v0.35.0-sec.3(sustaining team's own downstream fork, go 1.18+ compatible) which backports only the CVE-2026-33814 fix (SETTINGS_MAX_FRAME_SIZE=0 validation in processSettingsNoWrite) without requiring the toolchain bump. Same mechanism already used in this repo's release-4.18 branch for a different CVE (grpc-go fork), and in openshift/azure-disk-csi-driver-operator's own 4.12-4.15 PRs for this same CVE.Verified: