Skip to content

4.22-DNM DOWNSTREAM: <carry>: OCPBUGS-103516: Replace bbolt with patched fork … - #396

Draft
sdodson wants to merge 1 commit into
openshift:openshift-4.22from
sdodson:4.22-bbolt-madvise
Draft

4.22-DNM DOWNSTREAM: <carry>: OCPBUGS-103516: Replace bbolt with patched fork …#396
sdodson wants to merge 1 commit into
openshift:openshift-4.22from
sdodson:4.22-bbolt-madvise

Conversation

@sdodson

@sdodson sdodson commented Aug 5, 2026

Copy link
Copy Markdown
Member

…to remove MADV_RANDOM

Since Linux 6.4, MADV_RANDOM causes the kernel to aggressively evict mmap'd pages, resulting in major page faults on bbolt's database file and order-of-magnitude compaction duration increases. The RHEL 10 kernel will not revert this behavior change, so the fix must be in bbolt.

This adds a go.mod replace directive pointing to a patched bbolt fork with the MADV_RANDOM madvise hint removed. The replace should be dropped once the fix is merged upstream (etcd-io/bbolt#939).

Ref: etcd-io/bbolt#939
Ref: https://redhat.atlassian.net/browse/OCPBUGS-103516

Assisted-by: Claude Code (Opus 4.6)

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

…to remove MADV_RANDOM

Since Linux 6.4, MADV_RANDOM causes the kernel to aggressively evict
mmap'd pages, resulting in major page faults on bbolt's database file
and order-of-magnitude compaction duration increases. The RHEL 10 kernel
will not revert this behavior change, so the fix must be in bbolt.

This adds a go.mod replace directive pointing to a patched bbolt fork
with the MADV_RANDOM madvise hint removed. The replace should be dropped
once the fix is merged upstream (etcd-io/bbolt#939).

Ref: etcd-io/bbolt#939
Ref: https://redhat.atlassian.net/browse/OCPBUGS-103516

Assisted-by: Claude Code (Opus 4.6)
@openshift-ci-robot openshift-ci-robot added jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 5, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@sdodson: This pull request references Jira Issue OCPBUGS-103516, which is invalid:

  • expected the bug to target either version "4.22." or "openshift-4.22.", but it targets "5.0.0" instead
  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected Jira Issue OCPBUGS-103516 to depend on a bug targeting a version in 5.0.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

…to remove MADV_RANDOM

Since Linux 6.4, MADV_RANDOM causes the kernel to aggressively evict mmap'd pages, resulting in major page faults on bbolt's database file and order-of-magnitude compaction duration increases. The RHEL 10 kernel will not revert this behavior change, so the fix must be in bbolt.

This adds a go.mod replace directive pointing to a patched bbolt fork with the MADV_RANDOM madvise hint removed. The replace should be dropped once the fix is merged upstream (etcd-io/bbolt#939).

Ref: etcd-io/bbolt#939
Ref: https://redhat.atlassian.net/browse/OCPBUGS-103516

Assisted-by: Claude Code (Opus 4.6)

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai

coderabbitai Bot commented Aug 5, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 91a3d768-96ae-4c02-88b7-8aa889d7dcdb

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 5, 2026
@openshift-ci

openshift-ci Bot commented Aug 5, 2026

Copy link
Copy Markdown

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci

openshift-ci Bot commented Aug 5, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sdodson
Once this PR has been reviewed and has the lgtm label, please assign hasbro17 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sdodson

sdodson commented Aug 5, 2026

Copy link
Copy Markdown
Member Author

/payload-job periodic-ci-openshift-eng-ocp-perfscale-main-aws-4.22-nightly-x86-control-plane-fips-24nodes

/test perfscale-control-plane-6nodes

@openshift-ci

openshift-ci Bot commented Aug 5, 2026

Copy link
Copy Markdown

@sdodson: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-eng-ocp-perfscale-main-aws-4.22-nightly-x86-control-plane-fips-24nodes

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/1aa9cda0-90cc-11f1-8c35-9451b77da49f-0

@sdodson sdodson changed the title DOWNSTREAM: <carry>: OCPBUGS-103516: Replace bbolt with patched fork … 4.22-DNM DOWNSTREAM: <carry>: OCPBUGS-103516: Replace bbolt with patched fork … Aug 5, 2026
@sdodson

sdodson commented Aug 5, 2026

Copy link
Copy Markdown
Member Author

/test perfscale-payload-control-plane-6nodes

@openshift-ci

openshift-ci Bot commented Aug 5, 2026

Copy link
Copy Markdown

@sdodson: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants