DO NOT MERGE: OCPBUGS-103516: MADV_RANDOM removal on 4.22 (pre-6.4 kernel) - #400
DO NOT MERGE: OCPBUGS-103516: MADV_RANDOM removal on 4.22 (pre-6.4 kernel)#400hasbro17 wants to merge 1 commit into
Conversation
…perfscale Add a go.mod replace pointing bbolt at the openshift/bbolt release-5.0 fork (v1.4.3 with madvise(MADV_RANDOM) removed) on the openshift-4.22 branch, which runs on RHCOS9 / kernel 5.14 (el9_8). Purpose: a control-plane-fips-24nodes perfscale run to confirm removing MADV_RANDOM does not regress on a pre-6.4 kernel. The current 4.22 baseline (stock bbolt, MADV_RANDOM present) already performs well on el9_8 (compaction ~1.6s, low page faults), since the RHEL 9.6 page-cache revert carried forward; this run shows removal stays neutral there. Throwaway branch for data gathering only. Must not be merged. Ref: etcd-io/bbolt#939 Ref: https://redhat.atlassian.net/browse/OCPBUGS-103516 Assisted-by: Claude Code (Opus 4.8)
|
Pipeline controller notification For optional jobs, comment This repository is configured in: LGTM mode |
|
Skipping CI for Draft Pull Request. |
|
@hasbro17: This pull request references Jira Issue OCPBUGS-103516, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hasbro17 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/payload-job periodic-ci-openshift-eng-ocp-perfscale-main-aws-4.22-nightly-x86-control-plane-fips-24nodes |
|
@hasbro17: trigger 0 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command |
|
/payload-job periodic-ci-openshift-eng-ocp-perfscale-main-aws-4.22-nightly-x86-control-plane-fips-24nodes |
|
@hasbro17: trigger 0 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command |
|
/payload-job periodic-ci-openshift-eng-ocp-perfscale-main-aws-4.22-nightly-x86-control-plane-fips-24nodes |
|
@hasbro17: trigger 0 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command |
|
/payload-job pull-ci-openshift-eng-ocp-perfscale-main-aws-4.22-nightly-x86-control-plane-fips-24nodes |
|
@afcollins: trigger 0 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command |
|
/test pull-ci-openshift-eng-ocp-perfscale-main-aws-4.22-nightly-x86-control-plane-fips-24nodes |
|
/test perfscale-payload-control-plane-6nodes |
|
@hasbro17: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/test ? |
|
@jtaleric: The following commands are available to trigger required jobs: The following commands are available to trigger optional jobs: Use DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
DO NOT MERGE — throwaway PR for perfscale data gathering only.
Adds a
go.modreplace pointing bbolt at theopenshift/bbolt release-5.0fork (v1.4.3 with
madvise(MADV_RANDOM)removed) onopenshift-4.22,which runs on RHCOS9 / kernel 5.14 (el9_8).
Purpose: a
control-plane-fips-24nodesperfscale run to confirm removingMADV_RANDOMdoes not regress on a pre-6.4 kernel — closing the secondprong of the upstream argument (etcd-io/bbolt#939) that removal is safe on
older kernels.
Context: the current 4.22 baseline (stock bbolt, MADV_RANDOM present) already
performs well on el9_8 — compaction ~1.6s, major faults ~11.5/s — because the
RHEL 9.6 page-cache revert carried forward. This run should show removal stays
at parity (~1.6s), i.e. no regression.
Do not merge or review — this branch will be deleted once the data is
collected.
Ref: etcd-io/bbolt#939
Ref: https://redhat.atlassian.net/browse/OCPBUGS-103516