e2e-pool: Plumb in BASE_DOMAIN#2083
Conversation
hiveutil still defaults the base domain to new-installer.openshift.com, which is probably what we want since we (hive engineers) are the ones invoking it by hand, using the hive-team cluster as a hub, and will thus prefer less typing. But now that we're switching to a new AWS account for CI, we want the AWS-based e2e suites to use the new base domain. We recognize and default a `$BASE_DOMAIN` variable for e2e itself, but weren't yet plumbing it through to e2e-pool. Fix. HIVE-2259
|
/assign @dlom |
| ${REGION_ARG} \ | ||
| ${CREDS_FILE_ARG} \ | ||
| --pull-secret-file="${PULL_SECRET_FILE}" \ | ||
| --base-domain="${CLUSTER_DOMAIN}" \ |
There was a problem hiding this comment.
ntr: CLUSTER_DOMAIN is set based on BASE_DOMAIN depending whether we're using managed DNS or not
openshift-ci
Bot
added
the
approved
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 2uasimojo, dlom The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Well the plumbing is working. But somehow we're enabling managed DNS, despite explicitly disabling it in the test config. Actually, now that I look at it, we should be |
|
Of note: it doesn't look like we have a way to make clusterpool clusters use managed DNS. I'm not completely sure there's a use case for that in the first place, but I thought it was interesting. |
|
/hold Revision 5bbb192 was retested 3 times: holding |
openshift-ci
Bot
added
the
do-not-merge/hold
✓ test e2e-pool |
|
I mean /test e2e-pool |
|
also /hold cancel |
openshift-ci
Bot
removed
the
do-not-merge/hold
|
Okay, I'm sick of this -- infra flake on cleanup after the test succeeded. /override ci/prow/e2e-pool |
|
@2uasimojo: Overrode contexts on behalf of 2uasimojo: ci/prow/e2e-pool DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@2uasimojo: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Switch to the new AWS account which will be subject to the pruner. Because this account is pruned automatically, remove commentary about our bespoke one. We changed the default BASE_DOMAIN in the test scripts themselves via openshift/hive#2081 and openshift/hive#2083, so it is removed from the configuration. HIVE-2259
Switch to the new AWS account which will be subject to the pruner. Because this account is pruned automatically, remove commentary about our bespoke one. We changed the default BASE_DOMAIN in the test scripts themselves via openshift/hive#2081 and openshift/hive#2083, so it is removed from the configuration. HIVE-2259
Switch to the new AWS account which will be subject to the pruner. Because this account is pruned automatically, remove commentary about our bespoke one. We changed the default BASE_DOMAIN in the test scripts themselves via openshift/hive#2081 and openshift/hive#2083, so it is removed from the configuration. HIVE-2259
3 participants
hiveutil still defaults the base domain to new-installer.openshift.com, which is probably what we want since we (hive engineers) are the ones invoking it by hand, using the hive-team cluster as a hub, and will thus prefer less typing.
But now that we're switching to a new AWS account for CI, we want the AWS-based e2e suites to use the new base domain. We recognize and default a
$BASE_DOMAINvariable for e2e itself, but weren't yet plumbing it through to e2e-pool. Fix.HIVE-2259