hive/e2e-pool: actually disable managed DNS#42172
Conversation
This variable wasn't getting into the test because we weren't exporting it. Fix. HIVE-2259
|
/assign @dlom |
openshift-ci
Bot
added
the
approved
|
[REHEARSALNOTIFIER]
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals. Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
This actually might end up trimming a little time off the test run too, as we won't have to wait for the dnsendpoint controller. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 2uasimojo, dlom The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/pj-rehearse auto-ack |
It turns out we weren't actually disabling managed DNS for e2e-pool -- see openshift/release#42172. However, attempting to do so revealed a timing problem which was being papered over: We were using `oc wait` to wait for the controllers to become ready, but hive-operator hadn't yet gotten a chance to create those deployments. (When we were enabling managed DNS, that process took some time *and* waited for those deployments, so we never noticed.) With this commit, after waiting for the hive-operator deployment itself to become Available, we then wait for HiveConfig to report Ready, indicating that the operator has created the deployments.
|
Okay, these failz should be addressed by openshift/hive#2087; will retest once that lands. |
|
/pj-rehearse auto-ack |
✓ |
|
Oh. I'm going to need to backport #2087 to mce-2.3 and mce-2.2. |
It turns out we weren't actually disabling managed DNS for e2e-pool -- see openshift/release#42172. However, attempting to do so revealed a timing problem which was being papered over: We were using `oc wait` to wait for the controllers to become ready, but hive-operator hadn't yet gotten a chance to create those deployments. (When we were enabling managed DNS, that process took some time *and* waited for those deployments, so we never noticed.) With this commit, after waiting for the hive-operator deployment itself to become Available, we then wait for HiveConfig to report Ready, indicating that the operator has created the deployments.
|
/pj-rehearse pull-ci-openshift-hive-mce-2.3-e2e-pool Landed openshift/hive#2089 |
It turns out we weren't actually disabling managed DNS for e2e-pool -- see openshift/release#42172. However, attempting to do so revealed a timing problem which was being papered over: We were using `oc wait` to wait for the controllers to become ready, but hive-operator hadn't yet gotten a chance to create those deployments. (When we were enabling managed DNS, that process took some time *and* waited for those deployments, so we never noticed.) With this commit, after waiting for the hive-operator deployment itself to become Available, we then wait for HiveConfig to report Ready, indicating that the operator has created the deployments.
|
/pj-rehearse pull-ci-openshift-hive-mce-2.2-e2e-pool Landed openshift/hive#2090 |
|
@2uasimojo: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/pj-rehearse ack |
openshift-ci-robot
added
the
rehearsals-ack
4 participants
This variable wasn't getting into the test because we weren't exporting it. Fix.
HIVE-2259