Use default network type#2085
Conversation
Installer will default the network type to OVNKubernetes if not specified. We have been overriding it to OpenShiftSDN in the clusterresource builder used for hiveutil and thus e2e. This commit removes that override, letting the installer default it for resources provisioned through those code paths.
openshift-ci
Bot
added
the
approved
|
/assign @jstuever |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2085 +/- ##
==========================================
+ Coverage 57.38% 57.52% +0.13%
==========================================
Files 186 186
Lines 25712 25860 +148
==========================================
+ Hits 14756 14877 +121
- Misses 9717 9733 +16
- Partials 1239 1250 +11
|
|
Um, I don't know why that failed. The output looks copacetic. The time frame is reasonable. The time stamp on the last output before cleanup is an hour before the timeout message from the job runner. Did something hang while we were gathering logs/artifacts? /test e2e-pool |
Yeah, this is what it looks like: |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 2uasimojo, jstuever The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test e2e-pool Incidental error during cleanup, that we shouldn't allow to fail the whole test. Closing that gap via #2088. |
|
Well boo, my test succeeded, but the cleanup workflow failed :( /test e2e-pool |
|
/test e2e-pool infra flake |
|
/test unit seems stuck? |
|
Well, it passed previously, and I don't feel like retesting everything. /override ci/prow/unit |
|
@2uasimojo: Overrode contexts on behalf of 2uasimojo: ci/prow/unit DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test coverage known taint sorting flake |
|
@2uasimojo: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
infra flake after test succeeded |
3 participants
Installer will default the network type to OVNKubernetes if not specified. We have been overriding it to OpenShiftSDN in the clusterresource builder used for hiveutil and thus e2e. This commit removes that override, letting the installer default it for resources provisioned through those code paths.