e2e-pool: Improve cleanup artifact gathering#2086
Merged
openshift-merge-robot merged 1 commit intoAug 10, 2023
Merged
Conversation
We've been seeing some weird timeouts in e2e-pool where the test itself succeeds, but clusterclaim deletion hangs until the job times out and is killed by the monitor. Previously we had no good way to debug this because we had last captured manifests & logs *before* issuing the clusterclaim deletion. With this commit, we: - Do that deletion (and that of the clusterpools) in the background. - Re-capture logs and manifests periodically while we're waiting for cleanup to complete.
openshift-ci
Bot
added
the
approved
This was referenced Aug 10, 2023
Contributor
|
@2uasimojo: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Member
Author
|
/assign @dlom |
Contributor
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 2uasimojo, dlom The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We've been seeing some weird timeouts in e2e-pool where the test itself succeeds, but clusterclaim deletion hangs until the job times out and is killed by the monitor. Previously we had no good way to debug this because we had last captured manifests & logs before issuing the clusterclaim deletion.
With this commit, we: