Skip to content

DNM: vSphere legacy MachinePool template QA - #2951

Draft
bandrade wants to merge 1 commit into
openshift:masterfrom
bandrade:qa/vsphere-legacy-template-e2e
Draft

DNM: vSphere legacy MachinePool template QA#2951
bandrade wants to merge 1 commit into
openshift:masterfrom
bandrade:qa/vsphere-legacy-template-e2e

Conversation

@bandrade

@bandrade bandrade commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Temporary QA-only CI harness for the legacy vSphere MachinePool template scenario.

Do not merge. This draft will be closed only after test evidence and infrastructure cleanup are confirmed. It changes the focused test harness only; no product controller code is modified.

Runtime pinned by immutable digest:

  • Hive MCE 5.1.0, built from upstream revision 5068da0
  • OpenShift 4.17.0 x86_64 spoke, using the September 2024 installer behavior

The focused test proves:

  • the ClusterDeployment failure domain has no explicit topology template;
  • the existing worker MachineSet uses the legacy -rhcos-- template name, not the failure-domain name;
  • a new one-replica Hive MachinePool reuses that exact full template;
  • its Machine provisions, its Node becomes Ready, and the MachineSet reaches Ready 1 / Available 1;
  • the temporary MachinePool and MachineSets are removed before the normal spoke teardown.

Local validation completed:

  • post-install e2e package compile
  • focused vSphere actuator unit tests
  • shell syntax, formatting, and diff checks

This PR must remain draft and must not be merged.

Add a QA-only e2e fixture that runs the published MCE 5.1 Hive image against an OpenShift 4.17 spoke and verifies a new MachinePool preserves its install-time region/zone template. This commit is intentionally not mergeable.

Assisted-by: OpenAI
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 1, 2026
@openshift-ci

openshift-ci Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@coderabbitai

coderabbitai Bot commented Sep 1, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Comment @coderabbitai help to get the list of available commands.

@bandrade

bandrade commented Sep 1, 2026

Copy link
Copy Markdown
Contributor Author

/hold

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 1, 2026
@openshift-ci

openshift-ci Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bandrade
Once this PR has been reviewed and has the lgtm label, please assign suhanime for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bandrade

bandrade commented Sep 1, 2026

Copy link
Copy Markdown
Contributor Author

/test e2e-vsphere

@openshift-ci

openshift-ci Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

@bandrade: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant