CNTRLPLANE-1892: chore(e2ev2): fixup GCP API checks #7555
Conversation
openshift-ci
bot
added
the
do-not-merge/work-in-progress
openshift-ci-robot
added
the
jira/valid-reference
|
Skipping CI for Draft Pull Request. |
|
@sjenning: This pull request references CNTRLPLANE-1892 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target either version "4.22." or "openshift-4.22.", but it targets "openshift-4.21" instead. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
WalkthroughAdded an e2ev2 build tag to a v2 test, extended GCP platform test inputs to include NetworkConfig and WorkloadIdentity fields, relaxed two GCP error-message assertions to substring checks, and added immediate post-create deletions with new helper implementations for hosted cluster and node pool tests. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes ✨ Finishing touches
Comment |
openshift-ci
bot
added
approved
|
@sjenning: This pull request references CNTRLPLANE-1892 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target either version "4.22." or "openshift-4.22.", but it targets "openshift-4.21" instead. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/lgtm |
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
@sjenning: This pull request references CNTRLPLANE-1892 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target either version "4.22." or "openshift-4.22.", but it targets "openshift-4.21" instead. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@sjenning: This pull request references CNTRLPLANE-1892 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target either version "4.22." or "openshift-4.22.", but it targets "openshift-4.21" instead. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
no tests exercise e2e v2 atm so no value in running them /override ci/prow/e2e-aks |
|
@sjenning: Overrode contexts on behalf of sjenning: ci/prow/e2e-aks, ci/prow/e2e-aks-4-21, ci/prow/e2e-aws, ci/prow/e2e-aws-4-21, ci/prow/e2e-aws-upgrade-hypershift-operator, ci/prow/e2e-kubevirt-aws-ovn-reduced DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@sjenning: This pull request references CNTRLPLANE-1892 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target either version "4.22." or "openshift-4.22.", but it targets "openshift-4.21" instead. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@sjenning: This pull request references CNTRLPLANE-1892 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target either version "4.22." or "openshift-4.22.", but it targets "openshift-4.21" instead. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/test ? |
|
@sjenning: The following commands are available to trigger required jobs: The following commands are available to trigger optional jobs: Use DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test e2e-aws-techpreview |
|
/retest |
|
Still some failures. Will update soon. |
The last time the GCP API was changed, new required fields and field validations were added that broke e2e with TechPreview and e2e-v2. This commit makes the changes needed to make passing cases pass again.
|
/test e2e-aws-techpreview |
|
@sjenning: This pull request references CNTRLPLANE-1892 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target either version "4.22." or "openshift-4.22.", but it targets "openshift-4.21" instead. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| hc.Spec.Platform.GCP = &hyperv1.GCPPlatformSpec{ | ||
| Project: "my-project-123", | ||
| Region: "europe-west2", | ||
| NetworkConfig: hyperv1.GCPNetworkConfig{ |
There was a problem hiding this comment.
GCP rejection tests missing required fields in e2e-v2
Medium Severity
The "should reject when GCP project ID has invalid format" and "should reject when GCP region has invalid format" tests in api_ux_validation_test.go are missing the now-required NetworkConfig and WorkloadIdentity fields. The PR description states that spec.platform.gcp.workloadIdentity is now required, and the equivalent tests in create_cluster_test.go were correctly updated with these fields, but these tests were not. These tests will fail because the API will return a "missing required field" error instead of the expected format validation error.
|
@sjenning: This pull request references CNTRLPLANE-1892 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target either version "4.22." or "openshift-4.22.", but it targets "openshift-4.21" instead. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/test e2e-aks |
|
Techpreview is failing because of autonode, but it's a known flake. It'll get solved here: #7583 Thanks for the fixup! 🙏 |
|
/test e2e-aws |
|
/verified by e2e |
openshift-ci-robot
added
the
verified
|
@bryan-cox: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/override ci/prow/e2e-aws-techpreview |
openshift-ci
bot
removed
the
do-not-merge/hold
|
@sjenning: Overrode contexts on behalf of sjenning: ci/prow/e2e-aws-techpreview DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/hold Revision 5d21817 was retested 3 times: holding |
openshift-ci
bot
added
the
do-not-merge/hold
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
@sjenning: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
6 participants
There has been some API drift on GCP since e2e-v2 was originally committed.
These fields now have a 1 char minimum
spec.platform.gcp.networkConfig.network.namespec.platform.gcp.networkConfig.privateServiceConnectSubnet.nameAnd
spec.platform.gcp.workloadIdentityis now requiredThe email validation test cases now fail on the length requirement, not invalid format. Reducing the match string catches both.
Note
Updates tests to match current API and expand validation coverage.
spec.platform.gcp.workloadIdentityandspec.platform.gcp.networkConfigfields; adjust expected error substrings (e.g., name length to "may not be more than 63 bytes", project/region patterns, endpointAccess values)api_ux_validation_test.gowith comprehensive HostedCluster and NodePool validation scenarios (GCP WIF, resource labels, networking, services, issuerURL, autoscaling, Azure auth, AWS placement, Azure VM images)Written by Cursor Bugbot for commit 5d21817. This will update automatically on new commits. Configure here.