AUTOSCALE-535: default block device mappings

[maxcao13]

What this PR does / why we need it:

Default block device mappings if the user doesn't set them in OpenshiftEC2NodeClass.

We've seen a lot of flakes in the e2e-test-techpreview and e2e-aws-autonode prow jobs where what happens is that nodes churn because of DiskPressure.

I've also seen it in manual smoketesting as well, and to get around this I've created a custom nodeclass with more block device root storage.

Which issue(s) this PR fixes:

Fixes

Special notes for your reviewer:

Checklist:

• Subject and description added to both, commit and PR.
• Relevant issues have been referenced.
• This change includes docs.
• This change includes unit tests.

[openshift-ci-robot]

@maxcao13: This pull request explicitly references no jira issue.

Details

In response to this:

What this PR does / why we need it:

Default block device mappings if the user doesn't set them in OpenshiftEC2NodeClass.

We've seen a lot of flakes in the e2e-test-techpreview and e2e-aws-autonode prow jobs where what happens is that nodes churn because of DiskPressure.

I've also seen it in manual smoketesting as well, and to get around this I've created a custom nodeclass with more block device root storage.

Which issue(s) this PR fixes:

Fixes

Special notes for your reviewer:

Checklist:

• Subject and description added to both, commit and PR.
• Relevant issues have been referenced.
• This change includes docs.
• This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[coderabbitai]

Important

Review skipped

Auto reviews are limited based on label configuration.

🚫 Review skipped — only excluded labels are configured. (1)

• do-not-merge/work-in-progress

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

• 🔍 Trigger a full review

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: maxcao13
Once this PR has been reviewed and has the lgtm label, please assign devguyio for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[maxcao13]

/test e2e-aws-techpreview
/test e2e-aws-autonode

[enxebre]

this doesn't honour the current consumer facing API doc

	// BlockDeviceMappings to be applied to provisioned nodes.
	// +kubebuilder:validation:XValidation:message="must have only one blockDeviceMappings with rootVolume",rule="self.filter(x, has(x.rootVolume)?x.rootVolume==true:false).size() <= 1"
	// +kubebuilder:validation:MaxItems:=50
	// +optional
	BlockDeviceMappings []*BlockDeviceMapping `json:"blockDeviceMappings,omitempty"`

Please update that accordingly to clarify that the backend would preserve the ability to set a sane default subject to change if none provided

[enxebre]

any rationale we can add in a comment to pick this number?

[maxcao13]

I just added a comment that the CLI has code that picks 120 for default hcp nodepools. Seems reasonable to me:

hypershift/cmd/nodepool/aws/create.go

Lines 27 to 32 in 8be1d9c

	platformOpts := &AWSPlatformCreateOptions{
	InstanceType: "",
	RootVolumeType: "gp3",
	RootVolumeSize: 120,
	RootVolumeIOPS: 0,
	}

[openshift-ci-robot]

@maxcao13: This pull request references AUTOSCALE-535 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

What this PR does / why we need it:

Default block device mappings if the user doesn't set them in OpenshiftEC2NodeClass.

We've seen a lot of flakes in the e2e-test-techpreview and e2e-aws-autonode prow jobs where what happens is that nodes churn because of DiskPressure.

I've also seen it in manual smoketesting as well, and to get around this I've created a custom nodeclass with more block device root storage.

Which issue(s) this PR fixes:

Fixes

Special notes for your reviewer:

Checklist:

• Subject and description added to both, commit and PR.
• Relevant issues have been referenced.
• This change includes docs.
• This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[maxcao13]

/test e2e-aws-techpreview

[openshift-ci]

@maxcao13: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.