NE-2815: feat: configure HAProxy version selection

[jcmoraisjr]

What this PR does / why we need it:

Configures Hypershift with the new command-line options used to declare the available HAProxy versions in the current release, as well as the default HAProxy version in case it is not provided in the IngressController resource.

Which issue(s) this PR fixes:

Fixes https://redhat.atlassian.net/browse/NE-2815

Special notes for your reviewer:

Checklist:

• Subject and description added to both, commit and PR.
• Relevant issues have been referenced.
• This change includes docs.
• This change includes unit tests.

Summary by CodeRabbit

• New Features
  • Added support for configuring HAProxy 2.8 and 3.2 image variants.
  • Added a configurable default HAProxy version for ingress deployments.
  • These settings can now be supplied at runtime through deployment configuration.

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[openshift-ci-robot]

@jcmoraisjr: This pull request references NE-2815 which is a valid jira issue.

Details

In response to this:

What this PR does / why we need it:

Configures Hypershift with the new command-line options used to declare the available HAProxy versions in the current release, as well as the default HAProxy version in case it is not provided in the IngressController resource.

Which issue(s) this PR fixes:

Fixes https://redhat.atlassian.net/browse/NE-2815

Special notes for your reviewer:

Checklist:

• Subject and description added to both, commit and PR.
• Relevant issues have been referenced.
• This change includes docs.
• This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[jcmoraisjr]

We need openshift/cluster-ingress-operator#1498 being merged first

/hold

[coderabbitai]

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (6)

• control-plane-operator/controllers/hostedcontrolplane/testdata/ingress-operator/AROSwift/zz_fixture_TestControlPlaneComponents_ingress_operator_deployment.yaml is excluded by !**/testdata/**
• control-plane-operator/controllers/hostedcontrolplane/testdata/ingress-operator/GCP/zz_fixture_TestControlPlaneComponents_ingress_operator_deployment.yaml is excluded by !**/testdata/**
• control-plane-operator/controllers/hostedcontrolplane/testdata/ingress-operator/IBMCloud/zz_fixture_TestControlPlaneComponents_ingress_operator_deployment.yaml is excluded by !**/testdata/**
• control-plane-operator/controllers/hostedcontrolplane/testdata/ingress-operator/ModernTLS/zz_fixture_TestControlPlaneComponents_ingress_operator_deployment.yaml is excluded by !**/testdata/**
• control-plane-operator/controllers/hostedcontrolplane/testdata/ingress-operator/TechPreviewNoUpgrade/zz_fixture_TestControlPlaneComponents_ingress_operator_deployment.yaml is excluded by !**/testdata/**
• control-plane-operator/controllers/hostedcontrolplane/testdata/ingress-operator/zz_fixture_TestControlPlaneComponents_ingress_operator_deployment.yaml is excluded by !**/testdata/**

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 49bb41fe-8fcc-4515-a95f-1ff9be13fae4

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

📝 Walkthrough

Walkthrough

The ingress-operator deployment now accepts HAProxy 2.8 and 3.2 image references plus a default HAProxy version through environment variables. The deployment command passes these values using HAProxy-specific flags. adaptDeployment populates the environment variables, including a default version of 3.2, alongside the existing deployment configuration.

Suggested reviewers: muraee

🚥 Pre-merge checks | ✅ 11

✅ Passed checks (11 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly matches the change by describing HAProxy version selection configuration.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	No test files were changed and no Ginkgo titles appear in the touched ingress-operator files.
Test Structure And Quality	✅ Passed	No Ginkgo test code was added or modified in this PR; only deployment manifests and implementation changed.
Topology-Aware Scheduling Compatibility	✅ Passed	Only HAProxy env vars/args were added; no new nodeSelector, affinity, spread, toleration, or replica changes were introduced.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	No new Ginkgo e2e tests were added; the commit only updates ingress deployment manifests, code, and testdata fixtures.
No-Weak-Crypto	✅ Passed	Touched files only add HAProxy version env/args; no weak crypto, custom crypto, or secret-comparison code appears in the diff.
Container-Privileges	✅ Passed	The changed ingress-operator manifest and adapter only add HAProxy args/env vars; no privileged, host*, SYS_ADMIN, or allowPrivilegeEscalation settings are introduced.
No-Sensitive-Data-In-Logs	✅ Passed	No new logging was added; the changes only add HAProxy version args/envs and a package scan found no log calls exposing sensitive data.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 44.50%. Comparing base (09265ac) to head (1e1ac9a).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #9040   +/-   ##
=======================================
  Coverage   44.50%   44.50%           
=======================================
  Files         774      774           
  Lines       96980    96980           
=======================================
  Hits        43164    43164           
  Misses      50828    50828           
  Partials     2988     2988           

Files with missing lines	Coverage Δ
...ostedcontrolplane/v2/ingressoperator/deployment.go	62.06% <ø> (ø)

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[bryan-cox]

/retest

[jcmoraisjr]

openshift/cluster-ingress-operator#1498 merged 🎉

/unhold

[gcs278]

/test ?

[bryan-cox]

/lgtm

[gcs278]

This feature is only activated in techpreview, so lets make sure we run hypershift's techpreview job:

/test e2e-aws-ovn-conformance-techpreview

[openshift-merge-bot]

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aks
/test e2e-aws
/test e2e-aws-upgrade-hypershift-operator
/test e2e-azure-v2-self-managed
/test e2e-kubevirt-aws-ovn-reduced
/test e2e-v2-aws
/test e2e-v2-gke
/test unit
/test verify

[muraee]

/approve

[openshift-ci]

New changes are detected. LGTM label has been removed.

[jcmoraisjr]

Latest push updated ModernTLS testdata, added after this PR.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bryan-cox, jcmoraisjr, muraee

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [bryan-cox,muraee]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[gcs278]

/test e2e-aws-ovn-conformance-techpreview

[gcs278]

/pipeline required

[openshift-merge-bot]

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aks
/test e2e-aws
/test e2e-aws-upgrade-hypershift-operator
/test e2e-azure-v2-self-managed
/test e2e-kubevirt-aws-ovn-reduced
/test e2e-v2-aws
/test e2e-v2-gke
/test unit
/test verify

[cwbotbot]

Test Results

e2e-aws

• Status: ✅ PASS
• Started: 2026-07-23T00:00:27Z
• View Job
• View Job History

e2e-aks

• Status: ✅ PASS
• Started: 2026-07-22T19:35:31Z
• View Job
• View Job History

[jcmoraisjr]

Chai-bot helped me double checking that all the failures are either infra related or other flakiness. Giving them another chance.

/retest

[jcmoraisjr]

/retest

[openshift-ci]

@jcmoraisjr: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-ovn-conformance-techpreview	1e1ac9a	link	false	/test e2e-aws-ovn-conformance-techpreview

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.